791687 - Remove support for NSIS 2.33

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Brian R. Bondy [:bbondy]]

All build machines should be upgraded to use NSIS 2.46 now.  This bug is to remove the NSIS 2.33 related code which we no longer need to support.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

There may be some other stuff that I don't know about. I grepped for "2.33" but from that I think this is the only thing that should be removed.

Comment 2

[Brian R. Bondy [:bbondy]]

CC'ing aki and catlee for confirmation that we don't use NSIS 2.33 at all anymore.

Comment 3

[Aki Sasaki (not active)]

Afaik, the last remaining NSIS 2.33 jobs were the win32 l10n repacks, which are now using 2.46.

Comment 4

[Brian R. Bondy [:bbondy]]

I guess we can land (once reviewed) and see if anyone screams :)

Comment 5

[Robert Strong (they/them - no direct email)]

I'm fine with that... it can always be backed out.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 661790 [details] [diff] [review]
Patch v1

The same should be true for the !ifndef CallArtificialFunction block. r=me with that... if there are more we can get them later

Comment 7

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2

Rebased so it can land directly on m-c with no dependencies. Removed the extra block that rstrong mentioned.

Pushed to try and if that goes well I'll land on m-i.
Carrying forward r+.

Comment 8

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/mozilla-central/rev/568593839470

Comment 9

[Brian R. Bondy [:bbondy]]

Comment on attachment 661843 [details] [diff] [review]
Patch v2

[Approval Request Comment]
(snip)
Dependency of win8, please see reasoning in Bug 791019 Comment 35

Comment 10

[Brian R. Bondy [:bbondy]]

Comment on attachment 661843 [details] [diff] [review]
Patch v2

I'm going to do a rollup patch for the involved bugs for defaults handling on Windows 8 and ask for approval all at once in bug 791019.  If that lands on aurora and beta I'll update the tracking fields in this bug and post the changesets in this bug as well.

Comment 11

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/releases/mozilla-beta/rev/4130a141a36b
http://hg.mozilla.org/releases/mozilla-aurora/rev/030540c0d243