791953 - gfxFont.h(2080) : warning C4244: 'return' : conversion from 'double' to 'float', possible loss of data

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When I build debug build on Win7 with VC2010, I can see this warning for a long while:

> gfxFont.h(2080) : warning C4244: 'return' : conversion from 'double' to 'float', possible loss of data

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxFont.h#2079

Looks like the 1.0 and -1.0 should be 1.0f and -1.0f. Or the result type should be integer.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

The only user of the method is here:
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxUniscribeShaper.cpp#289

I think that the result type should be kept as float.

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 662381 [details] [diff] [review]
Patch

Review of attachment 662381 [details] [diff] [review]:
-----------------------------------------------------------------

Fine, thanks. (What a silly warning - the compiler can see it's a constant and won't lose anything...)

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6727fcb41025

Yeah, it's odd... But anyway, thank you for your review.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6727fcb41025