Closed
Bug 791983
Opened 12 years ago
Closed 12 years ago
Save users from polluting their dist/bin when building Lightning
Categories
(Calendar :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
|
1.41 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
make -C objdir/calendar will start a build that inserts all sorts of lightning specific files into dist/bin. Especially new developers will get thrown off by this. To counteract, I have done two things: 1. make -C objdir/calendar will call the calendar/lightning makefile instead 2. make -C objdir/calendar/base will set XPI_NAME too.
Attachment #662102 -
Flags: review?(mbanner)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 662102 [details] [diff] [review] Fix - v1 Review of attachment 662102 [details] [diff] [review]: ----------------------------------------------------------------- Ok, I think this looks reasonable to do.
Attachment #662102 -
Flags: review?(mbanner) → review+
|
||
Updated•12 years ago
|
Assignee: nobody → philipp
|
Assignee | |
Comment 2•12 years ago
|
||
Pushed to comm-central changeset 117e2e975798
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1
You need to log in
before you can comment on or make changes to this bug.
Description
•