792227 - error cleaning up on windows

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

DEBUG: initialized firefox.exe
DEBUG: command line: '"..\firefox\firefox.exe"  -profile
c:\\\users\\\cltbld\\\a
ppdata\\\local\\\temp\\\tmpwjhyfh\\\profile
startup_test/tresize-test.html'
DEBUG: unknown error during cleanup
Traceback (most recent call last):
  File "run_tests.py", line 298, in ?
    main()
  File "run_tests.py", line 295, in main
    run_tests(parser)
  File "run_tests.py", line 250, in run_tests
    talos_results.add(mytest.runTest(browser_config, test))
  File "C:\Users\cltbld\test\talos\ttest.py", line 417, in runTest
    self.cleanupProfile(temp_dir)
  File "C:\Users\cltbld\test\talos\ttest.py", line 147, in
  cleanupProfile
    self._hostproc.removeDirectory(dir)
  File "C:\Users\cltbld\test\talos\ffprocess.py", line 142, in
  removeDirectory
    shutil.rmtree(dir)
  File "C:\Python24\lib\shutil.py", line 163, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "C:\Python24\lib\shutil.py", line 163, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "C:\Python24\lib\shutil.py", line 168, in rmtree
    onerror(os.remove, fullname, sys.exc_info())
  File "C:\Python24\lib\shutil.py", line 166, in rmtree
    os.remove(fullname)
OSError: [Errno 13] Permission denied:
'c:\\users\\cltbld\\appdata\\local\\temp\
\tmpwjhyfh\\profile\\Cache\\_CACHE_001_'

C:\Users\cltbld\test\talos>Traceback (most recent call last):
  File "C:\Users\cltbld\test\talos\bcontroller.py", line 221, in ?
    sys.exit(main())
  File "C:\Users\cltbld\test\talos\bcontroller.py", line 218, in main
    bcontroller.run()
  File "C:\Users\cltbld\test\talos\bcontroller.py", line 161, in run
    results_file = open(self.browser_log, "a")
IOError: [Errno 13] Permission denied: 'browser_output.txt'

So....I'm not sure *why* this happens.  I do think we (mostly meaning
"me") need to finish mozfile and see if this problem occurs then.

Comment 1

[Jeff Hammel]

This is at least partially the result of the browser not being terminated after tresize :/

C:\Users\cltbld\test\talos>python run_tests.py -n -d -a tdhtmlr:tresize -e ../fi
refox/firefox.exe --datazilla-url https://datazilla.mozilla.org/test --authfile
../BuildSlaves.py

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

we haven't seen this lately, I believe a handful of small fixes have gone in to fix this.  Can we close this bug?