792330 - B2G MMS: MMSCONF-MED-C-0{06, 07, 08, 09, 10, 12, 15, 34, 35}: Support multiple media types

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

See OMA-TS-MMS-CONF-V1_3-20110913-A section 7, 7.1.1, and Appendix C.1.12
See OMA-ETS-MMS_CON-V1_3-20101015-C section 5.1.2.2.1, 5.1.2.2.2, 5.1.2.2.3, 5.1.2.2.4, 5.1.2.2.5, 5.1.2.2.6, 5.2.3.2.1, 5.2.3.2.2, 5.2.3.2.3, 5.2.3.2.4, 5.2.3.2.5, 5.2.3.2.6, 5.2.3.2.9

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

They are:
1) text/plain, encoding=us-ascii, utf-8, utf-16
2) image/jpeg
3) image/gif
4) image/vnd.wap.wbmp
5) audio/amr
6) vCard & vCalendar

But maybe we should just add as much media types as possible. Additional types to be addressed:
7) H.263 & AMR (3GP)
8) MP4
9) JFIF

Actually, I think we should just add everything listed in http://www.wapforum.org/wina/wsp-content-type.htm

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

I think we should follow the OMNA WSP Content Type Numbers which listed in http://www.openmobilealliance.org/tech/omna/omna-wsp-content-type.aspx

Because the types listed in http://www.wapforum.org/wina/wsp-content-type.htm’ are from 0x00 to 0x4B. The Content Type Numbers which listed in http://www.openmobilealliance.org/tech/omna/omna-wsp-content-type.aspx are from 0x00 to 0x5A (0x51 - 0x5A is tbd). It looks like the wsp content type listed in OMA is latest one.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Chia-hung Tai [:ctai :ctai_mozilla :cht] from comment #2)
> I think we should follow the OMNA WSP Content Type Numbers which listed in
> http://www.openmobilealliance.org/tech/omna/omna-wsp-content-type.aspx

Thanks. Please also updates the url in the comments of WspPduHelper.jsm

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Add all WSP content types into WSP_WELL_KNOWN_CONTENT_TYPES

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Add all WSP content types into WSP_WELL_KNOWN_CONTENT_TYPES

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Add all WSP content types into WSP_WELL_KNOWN_CONTENT_TYPES

Comment 7

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 683849 [details] [diff] [review]
Add all WSP content types into WSP_WELL_KNOWN_CONTENT_TYPES

Please help to review this patch.
Thanks

Comment 8

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Try server log:
https://tbpl.mozilla.org/?tree=Try&rev=db17a8d8467e

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 683849 [details] [diff] [review]
Add all WSP content types into WSP_WELL_KNOWN_CONTENT_TYPES

Review of attachment 683849 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/255d09298f9b

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/255d09298f9b

Comment 12

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

For mms merge to b2g18.

Comment 13

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: [b2g18]001-bug-792330-fix

Comment 14

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/95eb3483678c

Comment 15

[Ryan VanderMeulen [:RyanVM]]

The entire set of clian's pushes was backed out for multiple reasons.
https://tbpl.mozilla.org/?tree=Mozilla-B2g18&rev=a0b06192f882

1.) The tree rules are clear that you are not to land on top of bustage. At the time you pushed, both B2G Mn and B2G xpcshell had bustage from prior commits that hadn't been backed out yet.
2.) The tree rules are also clear that you are to watch your pushes for any bustage and handle them accordingly. mozilla-inbound is the ONLY tree where this rule does not apply.
3.) Even after the earlier bustage was backed out, something in one of your many pushes was causing further B2G Mn failures as shown in the log below.
https://tbpl.mozilla.org/php/getParsedLog.php?id=20424173&tree=Mozilla-B2g18
4.) This isn't cause for backout by itself, but it is also strongly preferred to not push each commit individually as our build and testing resources are limited and doing so stretches them even thinner. Please limit your number of pushes as much as possible unless you have good reason for keeping them separate.

Comment 16

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/99680a32f297