792392 - No special icon for secure connection in folder pane on linux

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Martin Schuster]

Attachment: Screenshot of secure icon on Mac

I've set up an IMAP/SSL connection. This should result in a "secure connection" icon in the folder pane (like in the first attachment, screenshot by Ludovic Hirlimann), but doesn't (see second attachment)

TB 17.0a2 running on RHEL5/x86-64

Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0a2
ID:20120918042014

Comment 1

[Martin Schuster]

Attachment: Screenshot of no secure icon on Linux

Comment 2

[Vincent (caméléon)]

Works for me on Win7.
Is there any other linux user which could confirm the issue on Linux?

Comment 3

[Martin Schuster]

I tried this on a completely different machine (running Debian wheezy, LXDE) and another IMAP-server (running on localhost), still no special icon. I've restarted TB, and also made sure that SSL is used:

$ netstat -tpn | grep thunder
tcp6       0      0 ::1:33802               ::1:993                 ESTABLISHED 9521/thunderbird
tcp6       0      0 ::1:33803               ::1:993                 ESTABLISHED 9521/thunderbird

Comment 4

[Martin Schuster]

Could someone tell me the filename of the icon that's supposed to show up?

I just tried to start TB via strace,
$ strace -efile -o st.log -f -a 60 ./thunderbird
and then looked for the missing icon,
$ grep ENOENT st.log | grep -i icon | egrep -i '(secu|ssl|enc|lock|prot)'
but nothing came up.

Comment 5

[Ludovic Hirlimann [:Usul]]

Andreas can you confirm ?

Comment 6

[Andreas Nilsson (:andreasn)]

Yes, if I recall correctly we don't have a specific security folder on Linux. Taking a step back, what function does the icon serve exactly and is a tiny padlock the best way to indicate the security of an account? Are there other ways we can indicate this?

Comment 7

[Vincent (caméléon)]

as Firefox also use a padlock for secure website, it makes sens to use the same convention.

Comment 8

[Andreas Nilsson (:andreasn)]

This is also the case on Windows it seems and the graphics is pretty much there already, so patch coming shortly.

Comment 9

[Wayne Mery (:wsmwk)]

next step is bug 448723 :)

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to Andreas Nilsson (:andreasn) from comment #8)
> This is also the case on Windows it seems and the graphics is pretty much
> there already, so patch coming shortly.

I'm going to assign you to this so you don't forget :-)

Comment 11

[Andreas Nilsson (:andreasn)]

:)

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: patch to fix the issue

Comment 13

[Andreas Nilsson (:andreasn)]

Attachment: patch to fix the issue (v2)

Comment 14

[Richard Marti (:Paenglab)]

Comment on attachment 669227 [details] [diff] [review]
patch to fix the issue (v2)

This looks good.

Only one note
Why add new icons on folder-pane.png when they already exist in server.png? I know they are looking different but you could update this file and change the rules to this file. For me it would be make more sense when the rule is: [IsServer="true"] then use server.png, like it's already for nntp.

This is only my opinion and the patch is doing what it should, so ui-r+

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 669227 [details] [diff] [review]
patch to fix the issue (v2)

Review of attachment 669227 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good. Thanks Andreas!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/81c5757e2e54

Comment 17

[Mark Banner (:standard8)]

Comment on attachment 669227 [details] [diff] [review]
patch to fix the issue (v2)

[Triage Comment]
We should take this forward to 17, as it is an issue there currently.

Comment 18

[:aceman]

Before you land this on TB17, please check this out:
For me on TB19 (trunk) all mail account icons changed to the new icon with lock. All my accounts are NOT secure: Connection security = None, Authentication = Password, transmitted insecurely.

Comment 19

[:aceman]

Please tell me what to test to determine if the problem is in the patch on my profile.

Comment 20

[:aceman]

... or my profile.

Comment 21

[Andreas Nilsson (:andreasn)]

Switching the security from SSH/SSL to None does indeed not change the icon, so I think you're right.
Does this work as expected on Windows and OSX?

Comment 22

[Richard Marti (:Paenglab)]

On Win7 this changes the icon.

Comment 23

[:aceman]

Yes, it works for me fine on Win XP (TB trunk).

Comment 24

[Mark Banner (:standard8)]

Comment on attachment 669227 [details] [diff] [review]
patch to fix the issue (v2)

Removing approvals until we get this fixed. I would like to get it fixed asap so that it'll work properly in TB 17.

Comment 25

[Richard Marti (:Paenglab)]

Attachment: Fix the issue

This patch fixes the issue there also insecure connections are shown as secure.

Comment 26

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 675153 [details] [diff] [review]
Fix the issue

Yes, this is right, thank you!

Comment 27

[Richard Marti (:Paenglab)]

Comment on attachment 675153 [details] [diff] [review]
Fix the issue

[Approval Request Comment]
Regarding comment 24 the patch and this fix are desired for TB 17

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/b738597de59f

(Assuming this gets branch approval, I can qfold these two patches into one for checkin)

Comment 29

[Mark Banner (:standard8)]

Comment on attachment 669227 [details] [diff] [review]
patch to fix the issue (v2)

a=me for both patches now that the issue is fixed.

Comment 30

[:aceman]

Confirming this works correctly on Linux in todays trunk.

Comment 31

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/538400c8b97d
https://hg.mozilla.org/releases/comm-aurora/rev/a8c4624b6a1d
https://hg.mozilla.org/releases/comm-beta/rev/ea9fc6bc25ab
https://hg.mozilla.org/releases/comm-beta/rev/a8fbe8ea2566