79251 - PAC: weekdayRange() see comment 8

Status: RESOLVED WONTFIX

(Core :: Networking, defect, P5)

Description

[[e-mail]]

Regarding deprecated function, here is implementation of weekdayRange():
------------------------------------------------------
var date = new Date();

var wdays = new Array("SUN", "MON", "TUE", "WED", "THU", "FRI", "SAT");

function weekdayRange() {
    function getDay(weekday) {
        for (var i = 0; i < 6; i++) {
            if (weekday == wdays[i])
                return i;
        }
        return -1;
    }
    var argc = arguments.length;
    var wday;
    if (argc < 1)
        return false;
    if (arguments[argc - 1] == "GMT") {
        argc--;
        wday = date.getUTCDay();
    } else {
        wday = date.getDay();
    }
    var wd1 = getDay(arguments[0]);
    var wd2 = (argc == 2) ? getDay(arguments[1]) : wd1;
    return (wd1 == -1 || wd2 == -1) ? false
                                    : (wd1 <= wday && wday <= wd2);

}

Comment 1

[benc]

qa to me
depends on 53080

Comment 2

[neeti]

-->PAC bugs to Jussi

Comment 3

[Jussi-Pekka Mantere]

Serge, can you take a look at these PAC issues? Thanks - Jussi-Pekka

Comment 4

[Blake Ross]

Doesn't look like this is getting fixed before the freeze tonight.
Pushing out a milestone.  Please correct if I'm mistaken.

Comment 5

[Chase Tingley]

I can't figure out what this bug is about -- the implementation given in the
summary went in as part of the PAC overhaul.  weekdayRange() is apparently
deprecated, but I assume that doesn't mean we're going to rip it out again.

I smell an easy resolution.  cc'ing gagan in case he knows something I don't.

Comment 6

[benc]

I filed it because I was trying to rip all issues out of the bugs that had
morphed into many-headed hydras.

If it works and it's in, we are good.

Comment 7

[Chase Tingley]

I did some basic testing to make sure that it behaves, and everything seems ok.

Marking FIXED.

Comment 8

[benc]

REOPEN: (Since there is only one bug in the history of this function...)

I've been writing a whitebox/harness test for this function, and found the following:

1- The number of arguments is not properly enforced because after GMT is stripped, the number of arguments is not enforced.

2- The wrap-around date is not supported.

Comment 9

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 10

[Valentin Gosu [:valentin] (he/him)]

I think at this point behaviour is well documented [1] and Chrome has the same implementation [2] as Firefox [3]

[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file#weekdayrange
[2] https://source.chromium.org/chromium/chromium/src/+/main:services/proxy_resolver/pac_js_library.h;l=128;drc=098756533733ea50b2dcb1c40d9a9e18d49febbe
[3] https://searchfox.org/mozilla-central/rev/2ce39261ea6a69e49d87f76a119494b2a7a7e42a/netwerk/base/ascii_pac_utils.js#96