792645 - Crash on startup.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Due to bug 756504.

09-20 09:54:13.135 W/System.err(  691): java.lang.NoSuchFieldError: no field with name='mDomKeyLocation' signature='I' in class Lorg/mozilla/gecko/GeckoEvent;
09-20 09:54:13.135 W/System.err(  691): 	at org.mozilla.gecko.GeckoAppShell.nativeInit(Native Method)
09-20 09:54:13.145 W/System.err(  691): 	at org.mozilla.gecko.GeckoAppShell.nativeInit(Native Method)
09-20 09:54:13.145 W/System.err(  691): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:392)
09-20 09:54:13.145 W/System.err(  691): 	at org.mozilla.gecko.GeckoApp$2.run(GeckoApp.java:294)
09-20 09:54:13.145 F/libc    (  691): Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1), thread 707 (Thread-81)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: quick fix

There are lots of duplicated codes between mobile/android/base/GeckoEvent.java and embedding/android/GeckoEvent.java. I am not sure mobile/xul is supported these days, if it is supported those codes should be unified...

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> Created attachment 662765 [details] [diff] [review]
> quick fix
> 
> There are lots of duplicated codes between
> mobile/android/base/GeckoEvent.java and embedding/android/GeckoEvent.java. I
> am not sure mobile/xul is supported these days, if it is supported those
> codes should be unified...

We should be dropping support for mobile/xul and embedding/android. In fact, we might be refactoring embedding/android to handle other bits of code.

Hiroyuki - How are you hitting this crash? What build are you using? Maybe you are making an unsupported build?

Comment 3

[Hiroyuki Ikezoe (:hiro)]

(In reply to Mark Finkle (:mfinkle) from comment #2)

> Hiroyuki - How are you hitting this crash? What build are you using? Maybe
> you are making an unsupported build?

Building Thunderbird with mobile/xul. ;-)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)
> (In reply to Mark Finkle (:mfinkle) from comment #2)
> 
> > Hiroyuki - How are you hitting this crash? What build are you using? Maybe
> > you are making an unsupported build?
> 
> Building Thunderbird with mobile/xul. ;-)

Why am I not surprised :)

If this patch works for you and Chris thinks it covers the changes made by bug 756504, I am fine with someone landing this. We should be moving toward a code refactor where you could build Thunderbird, or any Mozilla based app, on Android. Eventually, we'll get there.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #3)
> > (In reply to Mark Finkle (:mfinkle) from comment #2)
> > 
> > > Hiroyuki - How are you hitting this crash? What build are you using? Maybe
> > > you are making an unsupported build?
> > 
> > Building Thunderbird with mobile/xul. ;-)
> 
> Why am I not surprised :)
> 
> If this patch works for you and Chris thinks it covers the changes made by
> bug 756504, I am fine with someone landing this. We should be moving toward
> a code refactor where you could build Thunderbird, or any Mozilla based app,
> on Android. Eventually, we'll get there.

Great! I am glad to hear that.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Just watned to say Hiroyuki-san, you're my hero.  Thunderbird! \o/

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 662765 [details] [diff] [review]
quick fix

Review of attachment 662765 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks, Hiroyuki! :)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Pushed to Try since I don't see any results posted here. I'll land it if it goes green.
https://tbpl.mozilla.org/?tree=Try&rev=b6377046bd34

Also, Hiro, to make life easier for those committing on your behalf, please make sure your patches include all the necessary commit information in them. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen from comment #8)
> https://tbpl.mozilla.org/?tree=Try&rev=b6377046bd34

Green on Try (the Win7 m-oth failure was not from this).
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d44fb1eef16

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d44fb1eef16