792819 - [b2g-bluetooth] BluetoothService::Notify() won't be called after receiving agent events

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

I used latest code to pair with my HTC device but failed. I found that we did receive RequestConfirmation event in AgentEventFilter, in that case BluetoothService::Notify should be called because it registered for LOCAL_AGENT_PATH & REMOTE_AGENT_PATH in Init(). However, if Bluetooth was ever switched off, mBluetoothSignalObserverTable would be clear, and we won't register again.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v1 patch

Since mBluetoothSignalObserverTable (in BluetoothService) is cleared when we stop bluetooth, the entry of LOCAL_AGENT_PATH, REMOTE_AGENT_PATH, and BluetoothManager(/) which should be kept in the table are also removed. 

In this patch, we re-add these entries when bluetooth is started.

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final version, r=qdot

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=6fa22a8cd526

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f85da9a728de

Comment 6

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/f85da9a728de