Closed
Bug 792899
Opened 12 years ago
Closed 12 years ago
docshell/test/chrome/test_bug789773.xul introduced in Bug 789773 uses about:home which SeaMonkey doesn't have.
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: philip.chee, Assigned: mcsmurf)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
From Bug 789773 Comment 96: > (In reply to Philip Chee from comment #95) >> about:home doesn't exist in SeaMonkey. Can you use some other about: page >> like about:neterror ? > Fine by me assuming the test continues to pass. File a separate bug? I looked around and I think about:rights and about:support seem to be available to Firefox, SeaMonkey, and Mobile (xul, android). Will have to test of course.
Reporter | ||
Comment 1•12 years ago
|
||
Neil sez:
> These are all certain to exist:
> about:
> about:about
> about:addons (unsuitable, runs lots of script)
> about:buildconfig
> about:compartments (unsuitable, runs lots of script)
> about:config (unsuitable, runs lots of script)
> about:credits
> about:license
> about:logo
> about:memory (unsuitable, runs lots of script)
> about:mozilla
> about:neterror (unsuitable)
> about:newaddon (probably unsuitable)
> about:plugins (probably unsuitable)
> about:support (probably unsuitable)
Assignee | ||
Comment 2•12 years ago
|
||
Fixes the about:home issue only (tested it on try for Firefox and locally for SeaMonkey), the first test still fails: if (/browser.xul/.test(req.name)) { It's looking for browser.xul in the load request for the new window (SeaMonkey uses navigator.xul instead). Maybe another way/test can be uses here to check this: 1.36 ok(calledListenerForBrowserXUL, "Should have called the progress listener for browser.xul");
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 684992 [details] [diff] [review] Patch Although this fixes only one issue, it's better than nothing for now :) that way the test run does not have to wait for the timeout.
Attachment #684992 -
Flags: review?(bobbyholley+bmo)
Comment 4•12 years ago
|
||
Comment on attachment 684992 [details] [diff] [review] Patch I _think_ this is ok, but the different characteristics of all these builtin pages are all pretty tricky. So please grab a build right before bug 789773, and verify that the test still fails with this patch. If so, r=bholley, and thanks for fixing it. :-)
Attachment #684992 -
Flags: review?(bobbyholley+bmo) → review+
Assignee | ||
Comment 5•12 years ago
|
||
I created a try build without the patch from Bug 792899 and with the test fix from this bug here applied. The test failed as expected, as a consequence(?) other tests failed, too (though some of these seem to be known test failures; sample output). The browser failed to shutdown: 3687 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/docshell/test/chrome/test_bug789773.xul | Test timed out. 8545 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/test_focus.xul | Test timed out. 8625 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/test_nodesFromRect.html | Test timed out. 8628 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/test_popup_blocker_chrome.xul | Test timed out. 8629 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | 4 test timeouts, giving up. 8630 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | Skipping 479 remaining tests. 8631 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/test_popup_blocker_chrome.xul finished in a non-clean fashion, probably because it didn't call SimpleTest.finish() TEST-UNEXPECTED-FAIL | Shutdown | application timed out after 330 seconds with no output Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/c6a9dce2248a
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → mozilla20
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → bugzilla
Comment 6•12 years ago
|
||
(In reply to Frank Wein [:mcsmurf] from comment #5) > I created a try build without the patch from Bug 792899 and with the test > fix from this bug here applied. > The test failed as expected, as a consequence(?) other tests failed, too > (though some of these seem to be known test failures; sample output) Yep, that looks fine. Thanks for doing that!
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c6a9dce2248a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•