792901 - Grid layout is slightly off and can't be scrolled

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Jim Mathies [:jimm]]

These patches fix a few things:

- The grid layout was over estimating the number of items that can fit in a row. Nine bookmarks on the samsung tablet will reproduce the problem.

- Added inputProcessing support for various StartUI elements so that scrolling now works.

- Added 'Bookmarks' and 'Downloads' label links. Note in the design comps we also have entries such as "More Bookmarks" at the end of each set. These links have yet to be implemented.

- Added some debug labels to grid for easier debugging

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch v.1

Comment 2

[Jim Mathies [:jimm]]

Attachment: history.js line endings

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 663064 [details] [diff] [review]
patch v.1

I don't like that setting the "gridName" property has the non-obvious side effect of making arrangeItems work or not work depending on the value.  Could you change <property name="gridName"> to <method name="init"> and pass in the name as a parameter?  That should make it clearer that init() must be called when setting up the grid.

Comment 4

[Jim Mathies [:jimm]]

Attachment: remove crlf from grid.xml

Comment 5

[Jim Mathies [:jimm]]

Attachment: grid fixes v.1

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 664431 [details] [diff] [review]
grid fixes v.1

- added various ids, get rid of 'gridName'
- fixup arrangeItems for autocomplete
- dismiss the app bar when autocomplete is displayed
- added commenting
- added inputProcessing attribute for scrolling

Comment 7

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.