792916 - Theme locks breaks amo-master

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P5)

Description

[Andy McKay]

Deleting an addon.persona in AMO causes failures.

This is because Django collects all models (even uninstalled ones):

https://github.com/django/django/blob/master/django/db/models/options.py#L405

And then tries to delete the relevant tables. At some point mkt/reviewers is imported and so is registered as a table to be deleted. However the table does not exist on the test server. This causes failures like this:

https://ci.mozilla.org/job/amo-master/7376/testReport/junit/workspace.apps.addons.tests.test_models/TestAddonDelete/test_cascades/

This is a general problem with a model existing in one site (AMO) and the relevant review queue existing in another site (Marketplace).

Comment 1

[Andy McKay]

See also bug 792917.

Comment 2

[Kevin Ngo [:ngoke]]

Could I create a theme_locks_amo and theme_locks_mkt table to fix this? With the themes_lock_amo serving no practical purpose for AMO.

Comment 3

[Andy McKay]

Possibly, but it seems wierd to make a table that has no practical purpose.

Comment 4

[Kevin Ngo [:ngoke]]

It's also weird to have related models across two different sites :)

Comment 5

[Andy McKay]

It is indeed. Another possible plan, if personas are going on the marketplace, move them there and off AMO.

Comment 6

[Kevin Ngo [:ngoke]]

Yeah, but that would sort of break Personas on AMO for now. In the future, we can nuke it off AMO.

Comment 7

[Kevin Ngo [:ngoke]]

Are you able to reproduce this test failure locally? I'm having trouble doing that.

Comment 8

[Wil Clouser [:clouserw]]

(In reply to Andy McKay [:andym] from comment #5)
> It is indeed. Another possible plan, if personas are going on the
> marketplace, move them there and off AMO.

PRD and plan is being developed.

Comment 9

[Wil Clouser [:clouserw]]

I'm marking this as a p5 because I don't think "breaks amo-master" is actually *breaking amo-master*.  If that's not right, please let me know.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/838f5f1