793018 - Resizing sidebar is choppy

Status: NEW

(Firefox :: General, defect)

Description

[u279076]

I noticed today when testing the Social API that resizing the sidebar is kind of choppy. Gavin pointed out to me that he saw the same thing and that it was reproducible with the Bookmarks sidebar. I tested this and indeed the Bookmarks and History sidebars show the same choppiness. I did a quick comparison with the same profile in Firefox 4.0 and it's very smooth.

It would seem this could be a performance regression.

Comment 1

[u279076]

Note that I was testing with Firefox 18.0a1 Linux 64-bit build.

Comment 2

[u279076]

I can't seem to reproduce this on a new profile so it might have to do with some profile data. I don't have any add-ons installed but maybe something in my Bookmarks, History, or Session.

Comment 3

[u279076]

In retesting my profile on Firefox 4 I can reproduce the choppiness so I guess this is not a regression and is profile related. I'm going to bump this down to UNCONFIRMED for now until I can find some more concrete leads. Please advise how I might debug this further.

Thanks

Comment 4

[Mike Hommey [:glandium]]

I have the same problem, and I'd say choppy is almost an understatement.

Comment 5

[u279076]

(In reply to Mike Hommey [:glandium] from comment #4)
> I have the same problem, and I'd say choppy is almost an understatement.

Can you provide some specific details? My assumption is that there is something in the profile that causes this since I was not able to reproduce on a new profile. It would be helpful to know some specs about the computer you are using this on, add-ons and versions, plugins and versions, OS & version, other software running, etc.

If you are using Windows, it would be helpful to capture a SPS profile using the Gecko Profiler add-on. Let me know if you need help with that.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #5)
> If you are using Windows, it would be helpful to capture a SPS profile using
> the Gecko Profiler add-on. Let me know if you need help with that.

FYI, the SPS profiler also works on OSX and *I think* Linux.

Comment 7

[u279076]

(In reply to Lawrence Mandel [:lmandel] from comment #6)
> (In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #5)
> > If you are using Windows, it would be helpful to capture a SPS profile using
> > the Gecko Profiler add-on. Let me know if you need help with that.
> 
> FYI, the SPS profiler also works on OSX and *I think* Linux.

That wasn't my understanding. Benoit, can you please confirm?

Comment 8

[Mike Hommey [:glandium]]

Yeah, it works on linux, provided you enable the stack walking code and change one line of code. I'll try to do that some time next week.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

I can confirm that the profiler works on OSX.

Comment 10

[Benoit Girard (:BenWa)]

(In reply to Mike Hommey [:glandium] from comment #8)
> Yeah, it works on linux, provided you enable the stack walking code and
> change one line of code. I'll try to do that some time next week.

Yes, the backend on Linux is more restricted because of stability. We need to implement a few features to improve it.

Comment 11

[Marco Bonardo [:mak]]

since it's both bookmarks and social, sounds like a more generic perf problem with sidebars, moving to general for now.

Comment 12

[Albert Scheiner [:alberts]]

Seeing it on macOS 10.15 with FF 89.0b6