Closed
Bug 793085
Opened 12 years ago
Closed 12 years ago
Remove UseAzureContentDrawing() in favour of SupportsAzureContent()
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: ajones, Assigned: ajones)
References
Details
Attachments
(1 file)
4.88 KB,
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
UseAzureContentDrawing() is a public method that reveals the pref directly. This method is dangerous because it doesn't check if there is actually a valid backend configured and available.
Comment 1•12 years ago
|
||
Try run for e458a9661813 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=e458a9661813 Results (out of 66 total builds): exception: 16 success: 45 warnings: 2 failure: 3 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-e458a9661813
Comment 2•12 years ago
|
||
Try run for 923265ca25f0 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=923265ca25f0 Results (out of 6 total builds): success: 6 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-923265ca25f0
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Try run for e06b1935d532 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=e06b1935d532 Results (out of 90 total builds): success: 81 warnings: 9 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-e06b1935d532
Comment 5•12 years ago
|
||
Try run for e06b1935d532 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=e06b1935d532 Results (out of 92 total builds): success: 83 warnings: 9 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-e06b1935d532
Comment 6•12 years ago
|
||
Try run for e06b1935d532 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=e06b1935d532 Results (out of 93 total builds): success: 83 warnings: 10 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-e06b1935d532
Assignee | ||
Updated•12 years ago
|
Attachment #665765 -
Flags: review?(ncameron)
Comment 7•12 years ago
|
||
Comment on attachment 665765 [details] [diff] [review] Remove UseAzureContentDrawing() in favour of SupportsAzureContent() Review of attachment 665765 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #665765 -
Flags: review?(ncameron) → review+
Assignee | ||
Comment 8•12 years ago
|
||
See also https://tbpl.mozilla.org/?tree=Try&rev=b1ad5229d516
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 9•12 years ago
|
||
Green on Try. https://hg.mozilla.org/integration/mozilla-inbound/rev/aab010487a73
Flags: in-testsuite-
Keywords: checkin-needed
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aab010487a73
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•