Closed Bug 79336 Opened 23 years ago Closed 23 years ago

javascript strict warnings in findUtils.js

Categories

(SeaMonkey :: Search, defect, P4)

Product:
SeaMonkey
Component:
Search
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: bugzilla, Assigned: samir_bugzilla)

Details

(Keywords: helpwanted)

Attachments

(2 files)

Simon's patch
870 bytes, patch
samir_bugzilla
: review+
alecf
: superreview+
Details | Diff | Splinter Review
same patch as smfr's; fix 2nd instance of if (window.findDialog)
729 bytes, patch
samir_bugzilla
: review+
Details | Diff | Splinter Review 
JavaScript strict warning:
chrome://communicator/content/findUtils.js line 39: reference to undefined 
property window.findDialog

build 20010507
We need a if ("findDialog" in window && window.findDialog)

reassign-->samir
Assignee: matt → sgehani
Priority: -- → P4
Target Milestone: --- → mozilla0.9.5
Henrik,
Would you have time to come up with patches for all these search-related js
strict-mode warnings?  I can check them in for you.  Thanks.
Target Milestone: mozilla0.9.5 → Future
Attached patch Simon's patch — — Splinter Review 

    
    

    
  
Comment on attachment 52078 [details] [diff] [review]
Simon's patch

r=sgehani

        Attachment #52078 -
        Flags: review+

    
    

    
  
dveditz, please rs.  
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9.6

    
  
Keywords: patch

    
  
Keywords: review

    
    

    
  
mscott, please rs.

    
    

    
  
alecf, please rs.

    
    

    
  
Comment on attachment 52078 [details] [diff] [review]
Simon's patch

sr=alecf

        Attachment #52078 -
        Flags: superreview+

    
  
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Checked in.

    
    

    
  
Warning: reference to undefined property window.findDialog
Source File: chrome://communicator/content/findUtils.js
Line: 65
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  
Keywords: patch, 
          
            review → helpwanted
Target Milestone: mozilla0.9.6 → mozilla1.0.1

    
    

    
  
Comment on attachment 60571 [details] [diff] [review]
same patch as smfr's; fix 2nd instance of if (window.findDialog)

r=sgehani

        Attachment #60571 -
        Flags: review+

    
  
Keywords: review

    
  
Keywords: mozilla0.9.8

    
    

    
  
alecf: can you sr?

    
    

    
  
Comment on attachment 60571 [details] [diff] [review]
same patch as smfr's; fix 2nd instance of if (window.findDialog)

sr=alecf

    
    

    
  
marking fixed. stephend checked in the patch for me.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED

    
    

    
  
verified fixed in 20020115
Status: RESOLVED → VERIFIED

    
    

    
  
in the "The never ending story about strict warnings" I now see:

Warning: function findAgainInPage does not always return a value
Source File: chrome://communicator/content/findUtils.js
Line: 106
Source Code:
}

Should I reopen or open a bug bug?

    
    

    
  
New bug please.

    
    

    
  
bug 133675 opened with the new strict warning
Product: Core → SeaMonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: