Closed Bug 793886 Opened 12 years ago Closed 10 years ago

Say how long the log was before truncation

Categories

(Release Engineering :: General, enhancement, P3)

x86_64
Linux
enhancement

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 958327

People

(Reporter: jruderman, Unassigned)

Details

(Whiteboard: [buildbot])

Attachments

(1 file, 1 obsolete file)

"Output exceeded 52428800 bytes, remaining output has been truncated"

Should say how long the original was, so we know how close we are to getting everything visible.

(e.g. https://tbpl.mozilla.org/php/getParsedLog.php?id=15458553&tree=Firefox )
Attached patch patch (obsolete) — Splinter Review
I'm on a roll with issues related to Valgrind today.

This patch changes output to:

Output of x bytes exceeded y bytes, remaining output has been truncated

where x and y are numbers.
Assignee: nobody → gary
Status: NEW → ASSIGNED
Attachment #664309 - Flags: review?(catlee)
Comment on attachment 664309 [details] [diff] [review]
patch

To use a tuple on the RHS of %, you need to wrap it the tuple in parens.
Comment on attachment 664309 [details] [diff] [review]
patch

Review of attachment 664309 [details] [diff] [review]:
-----------------------------------------------------------------

that doesn't interpolate the way you want it to. also, that message is generated as soon as the log limit is exceeded, and we don't know how large the log is yet.
Attachment #664309 - Flags: review?(catlee) → review-
This merely provides more information about the amount of excess bytes it went over, it doesn't yet address the issue catlee pointed out, who suggests that we might have to wait till the end, in finish().
Attachment #664309 - Attachment is obsolete: true
Unfortunately I have to punt on this.
Assignee: gary → nobody
Status: ASSIGNED → NEW
Priority: -- → P3
Whiteboard: [buildbot]
Product: mozilla.org → Release Engineering
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: