794127 - hal::AdjustSystemClock should take a 64-bit value

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Justin Lebar (not reading bugmail)]

Right now, hal::AdjustSystemClock takes a signed 32-bit delta, representing the number of ms we want to move the clock forward or backwards.

That means we can't adjust the system clock more than 2^31 / (24 * 60 * 60 * 1000) = 25 days!!

We need to change this to a 64-bit value.  I'd also be OK if we changed it to take an absolute date, instead of an interval.  That might be slightly less accurate, but I'm not sure it matters.

Comment 1

[Justin Lebar (not reading bugmail)]

I think this bug will make us incapable of properly setting the system clock when we receive the time from a cell tower, if the system time is more than 25 days off from the cell tower.  Ouch.

Comment 2

[Justin Lebar (not reading bugmail)]

Gene, do you want to take this one?

Comment 3

[Gene Lian (I already quit Mozilla)]

Make sense to me! Should be able to come back with the patch very soon.

Comment 4

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Changes are trivial. s/int32_t/int64_t. Please let me know if any details can be improved. Thanks!

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b444917f491

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6b444917f491