794212 - Debug build: Assertion failure and crash when starting drag and drop in calendar view

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Starting an event drag and drop operation in calendar view of a Debug build asserts and the application crashes.

> Assertion failure: mInitialized, at .../src/mozilla/widget/xpwidgets/nsTransferable.cpp:447

Reason is that init() of the nsITransferable object has not be called.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: fix assertion failure and crash

Add missing calls to init(). I'd say we don't care about Private Browsing mode and therefore we can just pass null to init() according to description in http://mxr.mozilla.org/comm-central/source/mozilla/widget/nsITransferable.idl#90

Comment 2

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/comm-central/rev/6482051d15a7

Comment 3

[Stefan Sitter [:ssitter]]

Comment on attachment 664628 [details] [diff] [review]
fix assertion failure and crash

When trying to verify another bug in debug build I ran into this crash very often when using drag and drop or copying an event to clipboard. The patch and its risk for regressions are very small therefore I'd like to port this back to 1.9 beta.

Comment 4

[Stefan Sitter [:ssitter]]

Ported back to https://hg.mozilla.org/releases/comm-beta/rev/2fe681068001