795134 - Remove localStorage when clear private data API is used

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Mounir Lamouri (:mounir)]

The code is ready, we just need to hook it with the correct notification.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

And Appcache!

CC'ing the necko folks so that they are aware of these plans.

Comment 2

[Mounir Lamouri (:mounir)]

I put them together because I will work on those. I could do appcache if needed.

Comment 3

[Jason Duell]

Appcache is handled already by bug 786299.  I'm taking cookies in bug 795203.

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 666005 [details] [diff] [review]
Patch

Review of attachment 666005 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/src/storage/nsDOMStorage.cpp
@@ +324,3 @@
>  
> +    uint32_t appId = nsIScriptSecurityManager::NO_APP_ID;
> +    bool browserOnly = false;

Nit: No need to initialize these if you're checking for failures below.

Comment 6

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e63fa4a848a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e63fa4a848a