Closed
Bug 795959
Opened 12 years ago
Closed 12 years ago
Typing "@gmail.com" as part of the username shouldn't be required when setting up a gtalk account
Categories
(Thunderbird :: Instant Messaging, enhancement)
Thunderbird
Instant Messaging
Tracking
(thunderbird17 fixed)
RESOLVED
FIXED
Thunderbird 18.0
Tracking | Status | |
---|---|---|
thunderbird17 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
()
Details
Attachments
(1 file, 1 obsolete file)
6.47 KB,
patch
|
clokep
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Guessing if the domain is @gmail.com or @googlemail.com is possible if we implement a Google specific XMPP extension documented at https://developers.google.com/talk/jep_extensions/jid_domain_change I think we should do it to avoid some confusion.
Assignee | ||
Comment 1•12 years ago
|
||
This patch works only if bug 786684 is fixed.
Assignee: nobody → florian
Attachment #666597 -
Flags: review?(clokep)
Comment 2•12 years ago
|
||
Comment on attachment 666597 [details] [diff] [review] Patch The code looks good, but I think I'd like a comment above PlainFullBindAuth pointing to the link you provide in this bug and a comment above the "if (!this._jid.node) {" block describing what is happening in this situation.
Attachment #666597 -
Flags: review?(clokep) → review-
Comment 3•12 years ago
|
||
Also, the corresponding Instantbird bug: https://bugzilla.instantbird.org/show_bug.cgi?id=1535
Assignee | ||
Comment 4•12 years ago
|
||
Same patch with more comments.
Attachment #666597 -
Attachment is obsolete: true
Attachment #666947 -
Flags: review?(clokep)
Comment 5•12 years ago
|
||
Comment on attachment 666947 [details] [diff] [review] Patch v2 Excellent. Thanks for fixing this!
Attachment #666947 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b176895f1b15
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Assignee | ||
Comment 7•12 years ago
|
||
http://hg.instantbird.org/instantbird/rev/c90d46307450
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 666947 [details] [diff] [review] Patch v2 [Approval Request Comment] If we take this patch, users won't have to type @gmail.com any more when configuring Google Talk account (ie less possible ways to mis configure a Google Talk account).
Attachment #666947 -
Flags: approval-comm-aurora?
Updated•12 years ago
|
Attachment #666947 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 9•12 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/583b589da03e
status-thunderbird17:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•