796061 - Remove nsIContent hashtables from nsBindingManager.

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[William Chen [:wchen]]

nsBindingManager has some hashtables that store XBL information about nsIContent. This information can be stored on the nsIContent and would naturally lead to a simpler API because you wouldn't need to obtain the binding manager for getting and setting the XBL attributes.

Comment 1

[William Chen [:wchen]]

Attachment: Part 1: Remove mBindingTable from nsBindingManager.

Comment 2

[William Chen [:wchen]]

Attachment: Part 2: Remove mInsertionParentTable from nsBindingManager.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'm worried that this is going to bitrot the patches in bug 653881 a bunch. Would it be worth trying to drive those into the tree instead?

Or is the idea to do so piece-wise and this is part of that?

Comment 4

[William Chen [:wchen]]

(In reply to Jonas Sicking (:sicking) from comment #3)
> I'm worried that this is going to bitrot the patches in bug 653881 a bunch.
> Would it be worth trying to drive those into the tree instead?
> 
> Or is the idea to do so piece-wise and this is part of that?

I've based these patches on top of bug 653881 so I depend on the other patches going in the tree first.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ooh, I see! Awesome!

Comment 6

[William Chen [:wchen]]

Attachment: Bug 796061 - Part 1: Remove mBindingTable from nsBindingManager.

Comment 7

[William Chen [:wchen]]

Attachment: Part 2: Remove mInsertionParentTable from nsBindingManager.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 764490 [details] [diff] [review]
Bug 796061 - Part 1: Remove mBindingTable from nsBindingManager.

Review of attachment 764490 [details] [diff] [review]:
-----------------------------------------------------------------

It seems like NODE_MAY_BE_IN_BINDING_MGR might be a prime target for collection after this patch.

Comment 9

[William Chen [:wchen]]

Attachment: Part 1: Remove mBindingTable from nsBindingManager.

Comment 10

[William Chen [:wchen]]

Attachment: Remove mBindingTable from nsBindingManager. v1 diff v2

Comment 11

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e3d564cd1b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/d810dcc0726f

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e3d564cd1b5
https://hg.mozilla.org/mozilla-central/rev/d810dcc0726f