Closed Bug 796309 Opened 12 years ago Closed 12 years ago

opening an existing chatwindow doesn't invoke the callback.

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox17 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 18
Tracking Flags:
Tracking Status
firefox17 --- fixed

People

(Reporter: markh, Assigned: markh)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

make callback when existing chat window is found, plus tests
3.04 KB, patch
mixedpuppy
: review+
Gavin
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
I *think* that if openChatWindow is invoked with a URL that is already open, the chat window will be restored, but the callback param will not be called.
Assignee: nobody → mhammond
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

        Attachment #667333 -
        Flags: review?(mixedpuppy)

        Attachment #667333 -
        Flags: review?(mixedpuppy) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/a31ce2d6d28e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18

        Attachment #667333 -
        Flags: approval-mozilla-aurora+

    
    

    
  
Patch appears to include some tests, in-testsuite?
Flags: in-testsuite?
Whiteboard: [qa-]
Flags: in-testsuite? → in-testsuite+

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: