796350 - volume control autorepeat does not work correctly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[GH to BZ]

[GitHub issue by davidflanagan on 2012-05-29T18:54:08Z, https://github.com/mozilla-b2g/gaia/issues/1514]
The volume control buttons on the phone are currently implemented in a very hacky way.  Both Gecko and Gaia listen for volume key events.  Gecko actually changes the volume when it sees them, and Gaia just updates the on-screen volume indicator when it sees the events.  This works if Gecko and Gaia do exactly the same thing for each event.

The bug is that Gaia currently implements auto-repeat functionality, so you can press and hold the volume up or volume down buttons.  And Gecko does not implement this, so the two can easily get out of sync.

Ideally, gaia would have a way to set the system volume, or gecko would have a way to notify gaia when the volume has been changed, so only one is in charge of the volume.  But failing that, gecko needs to implement the same autorepeat functionality that gaia has.

Comment 1

[GH to BZ]

[GitHub comment by timdream on 2012-05-30T09:48:38Z]
Almost all the issues that related to volume is because of this one.

@jammink @tonychung please link (and close) there issue to this issue, thanks.

Comment 2

[GH to BZ]

[GitHub comment by tonychung on 2012-05-30T14:17:13Z]
Is there a bugzilla bug that someone can add here that tracks the work on the gecko side?

Comment 3

[Marco Chen [:mchen]]

Sound manager set audio volume into Gecko via settings with observer event. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/sound_manager.js#L98
And sound manager get this observer event to set current volume too. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/sound_manager.js#L20

The problem may occurred on synchronization between "https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/sound_manager.js#L20" and next repeating key event for changing audio volume. Once repeating key events are faster then observer event then bug is appeared.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug is extremely old. I wonder why it was not closed?

(In reply to Marco Chen [:mchen] from comment #3)
> The problem may occurred on synchronization between
> "https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/
> sound_manager.js#L20" and next repeating key event for changing audio
> volume. Once repeating key events are faster then observer event then bug is
> appeared.

The behavior you described is covered in bug 796734.

Comment 5

[John Hammink]

Otoro daily: 10-11-2012
* gaia: 2667536e3b06e46dd193aa6d76ba08dad2d867be
* gonk: 6ec34aa3d66331054de37eabc594ad923654b27c

Pressing and holding volume button up or down results in a smooth transition of volume (none of the choppiness described in 796734).   Marking "verified".