Closed
Bug 796730
Opened 12 years ago
Closed 11 years ago
[calendar] Scroll Bar shouldn't extend to the header
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)
Firefox OS Graveyard
Gaia::Calendar
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: ghtobz, Assigned: dkuo)
Details
(Keywords: polish, Whiteboard: visual design, incorrect implementation)
Attachments
(1 file)
[GitHub issue by patrykdesign on 2012-09-25T16:21:15Z, https://github.com/mozilla-b2g/gaia/issues/5150] The scroll bar is drawn on top of the header. It should stop right below it. See screenshot = http://cl.ly/image/0S3l1j300k31 This seems to be an issue in Calendar, Email potentially other apps but not Music. @asutherland @lightsofapollo
[GitHub comment by asutherland on 2012-09-25T16:26:54Z] @steveck-chung @dominickuo We can probably fix this. This was done initially as the easiest way to satisfy the "hide the search screen UI" under the top. We can change the scroll region to just be below the header and have an initial scrolled offset to hide the search UI instead. (The search UI had been disabled because it was a lie since, however.)
Updated•12 years ago
|
Assignee: schung → dkuo
Updated•12 years ago
|
Component: Gaia → Gaia::Calendar
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #669476 -
Flags: review?(bugmail)
Updated•12 years ago
|
Attachment #669476 -
Flags: review?(bugmail) → review+
Comment 3•12 years ago
|
||
Landed on gaia master: https://github.com/mozilla-b2g/gaia/commit/9496abb7ed1cdbefd88a58fcc7bef8f7cd099e1b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
Oops, just realized this was in the calendar component right now. Well, consider the email bit fixed as of: https://github.com/mozilla-b2g/gaia/commit/9496abb7ed1cdbefd88a58fcc7bef8f7cd099e1b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•12 years ago
|
Priority: -- → P3
Updated•12 years ago
|
Whiteboard: [label:calendar][label:needsVISUALinput][label:email][label:polish][label:email-ui] → [label:calendar][label:needsVISUALinput][label:email][label:polish][label:email-ui] polish
Updated•12 years ago
|
Summary: [calendar][email] Scroll Bar shouldn't extend to the header → [calendar] Scroll Bar shouldn't extend to the header
Whiteboard: [label:calendar][label:needsVISUALinput][label:email][label:polish][label:email-ui] polish → [label:calendar][label:needsVISUALinput][label:polish] polish
Updated•12 years ago
|
Whiteboard: [label:calendar][label:needsVISUALinput][label:polish] polish → [label:calendar][label:needsVISUALinput][label:polish
Updated•12 years ago
|
Keywords: polish
Whiteboard: [label:calendar][label:needsVISUALinput][label:polish → [label:calendar][label:needsVISUALinput][label:polish]
Updated•12 years ago
|
Whiteboard: [label:calendar][label:needsVISUALinput][label:polish] → visual design, incorrect implementation
Comment 5•11 years ago
|
||
Dominic, has this bug been fixed for calendar? I've checked on the 2013-03-11 gaia/master build and it seems to have been fixed cause I can't find a scroll bar that goes into the header. But I'm not sure what I'm looking for since the original screen cap link is broken. I'll close this bug if it's fixed. Thx!
Flags: needinfo?(dkuo)
Assignee | ||
Comment 6•11 years ago
|
||
Eric, from the bugzilla log above, you can see this bug was for both email and calendar, my patch was for email only, but I believe there is another split bug for calendar to fix this(I cannot find it), and already been fixed just like you said, so I think we can close this one, thanks.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 11 years ago
Flags: needinfo?(dkuo)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•