Closed
Bug 797021
Opened 12 years ago
Closed 12 years ago
"background-clip: content-box, border-box" does not seem to work
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
Tracking | Status | |
---|---|---|
firefox16 | --- | unaffected |
firefox17 | --- | unaffected |
firefox18 | + | fixed |
firefox19 | + | fixed |
People
(Reporter: bzbarsky, Assigned: cwiiis)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
2.25 KB,
patch
|
roc
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
2.64 KB,
patch
|
roc
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
testcase, to run from the srcdir: <style> div { background-image: url(layout/reftests//backgrounds/aqua-32x32.png), url(layout/reftests//backgrounds/green-16x20.png); border: 20px solid transparent; background-clip: content-box, border-box; width: 100px; height: 100px; } </style> <div></div> This shows only aqua, no green. That seems broken to me...
Comment 1•12 years ago
|
||
Also seeing this, works on beta (17), broken on aurora(18).
Reporter | ||
Comment 2•12 years ago
|
||
Oh, interesting! I didn't realize this used to work. Hector, are you willing to find a regression range?
status-firefox16:
--- → unaffected
status-firefox17:
--- → unaffected
status-firefox18:
--- → affected
status-firefox19:
--- → affected
tracking-firefox18:
--- → ?
tracking-firefox19:
--- → ?
Keywords: regression,
regressionwindow-wanted
Comment 3•12 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #2) > Oh, interesting! I didn't realize this used to work. > > Hector, are you willing to find a regression range? I'd like to, just need to be patient for the slow downloading.
Reporter | ||
Comment 4•12 years ago
|
||
OK. Let me know if you're having trouble with it, alright?
Comment 5•12 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #2) > Oh, interesting! I didn't realize this used to work. > > Hector, are you willing to find a regression range? And the regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f36b93c70d05&tochange=e5af3d785252
Reporter | ||
Comment 6•12 years ago
|
||
Hmm. Probably a regression from bug 786502, then. Chris, can you take a look?
Blocks: 786502
Keywords: regressionwindow-wanted
Updated•12 years ago
|
Assignee | ||
Comment 7•12 years ago
|
||
Fix the issue. reftest patch incoming.
Attachment #677367 -
Flags: review?(roc)
Assignee | ||
Comment 8•12 years ago
|
||
Turn the test case in comment #0 into a reftest.
Attachment #677375 -
Flags: review?(roc)
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•12 years ago
|
||
hmm, not quite, this breaks another reftest... https://tbpl.mozilla.org/?tree=Try&rev=bef23e002e21
Assignee | ||
Comment 10•12 years ago
|
||
Remember to draw all layers when aLayer < 0.
Attachment #677367 -
Attachment is obsolete: true
Attachment #677367 -
Flags: review?(roc)
Attachment #677436 -
Flags: review?(roc)
Comment on attachment 677436 [details] [diff] [review] Fix border clipping on backgrounds with multiple layers Review of attachment 677436 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #677436 -
Flags: review?(roc) → review+
Attachment #677375 -
Flags: review?(roc) → review+
Assignee | ||
Comment 12•12 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/da40e6f95147 https://hg.mozilla.org/integration/mozilla-inbound/rev/324d0fbac2fd
Assignee | ||
Comment 13•12 years ago
|
||
Will wait over the weekend, then assuming there are no problems, request aurora approval.
Assignee | ||
Comment 14•12 years ago
|
||
Silly signed/unsigned follow-up to fix debug build bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/772a4bb004ad
Comment 15•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/da40e6f95147 https://hg.mozilla.org/mozilla-central/rev/324d0fbac2fd https://hg.mozilla.org/mozilla-central/rev/772a4bb004ad
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment 16•12 years ago
|
||
(In reply to Chris Lord [:cwiiis] from comment #13) > Will wait over the weekend, then assuming there are no problems, request > aurora approval. Hi, Any ETA of this aurora uplift? Thanks!
Assignee | ||
Comment 17•12 years ago
|
||
Comment on attachment 677436 [details] [diff] [review] Fix border clipping on backgrounds with multiple layers [Approval Request Comment] Bug caused by (feature/regressing bug #): border clipping on multi-layer backgrounds breaks. User impact if declined: Using this feature will result in incorrect rendering Testing completed (on m-c, etc.): Been on m-c a while now with no apparent ill effect Risk to taking this patch (and alternatives if risky): Low-Medium. I'd have thought breakage ought to be obvious, but I wouldn't want to assume. String or UUID changes made by this patch: None.
Attachment #677436 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 18•12 years ago
|
||
Comment on attachment 677375 [details] [diff] [review] Reftest [Approval Request Comment] Bug caused by (feature/regressing bug #): Test-case for the feature this bug fixes User impact if declined: We may accidentally break this feature(?) Testing completed (on m-c, etc.): Reftest has been running fine since push. Risk to taking this patch (and alternatives if risky): Practically nil. String or UUID changes made by this patch: None.
Attachment #677375 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 19•12 years ago
|
||
Thanks for the reminder, Hector, I'd totally forgotten!
Updated•12 years ago
|
Attachment #677375 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•12 years ago
|
Attachment #677436 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 20•12 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/releases/mozilla-aurora/rev/d422c11c91fe https://hg.mozilla.org/releases/mozilla-aurora/rev/996854233577 https://hg.mozilla.org/releases/mozilla-aurora/rev/668d088cd209
You need to log in
before you can comment on or make changes to this bug.
Description
•