797113 - Form on VIA Rail Canada site not rendering properly (TypeError: Value not an object)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mark Côté [:mcote]]

Attachment: Broken form, Nightly 18.0a (2012-10-02)

I tried to book a train through VIA Rail Canada today, and a bug in the former parsing rendered this impossible. I was able to use release firefox with no problems. I am using nightly 18.0a1 2012-10-02.

Steps:

* Go to www.viarail.ca
* Use the form on the left to start the booking process, e.g. MONTRÉAL, QC to TORONTO, ON, departure date 11/09/2012, return date 11/10/2012, 1 adult.
* Click search.
* Pick a train, e.g. 6:20 am supersaver economy.
* Click continue at bottom of table.
* Pick another train, e.g. 6:40 am supersaver economy.
* Click continue at bottom of table.
* On next screen, click Continue at bottom.

Expected:

The form displays normally with no repeated fields and the ability to choose a Province / State.

Actual:

The two phone number fields are duplicated. The next above it reads "Phone Number
(Country code) Phone Number *" and "Cell Phone Number (Country code) Cell Phone Number". There are four entry boxes for each phone number instead of two. Most importantly, the Province / State drop down has only one option, "empty". Selecting another country, e.g. United States, does not change this. The Continue button will not work without a valid province/state selected.

I am attaching screenshots of the broken nightly and the working release (v15.0.1)

Comment 1

[Mark Côté [:mcote]]

Attachment: Working form, Release 15.0.1 (Ubuntu 12.04 32-bit)

The screenshot from Release firefox was actually taken on a different computer. Same OS (Ubuntu 12.04) except that Nightly is running on a 64-bit system and Release on a 32-bit.

Comment 2

[Mark Côté [:mcote]]

*Bug in the form parsing, not former parsing.

Comment 3

[Loic]

It's a regression from yesterday:

m-c
2012-10-01
2012-10-02
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=beee809b7ade&tochange=85dd8e346102

Comment 4

[Loic]

It looks like an issue with parsing style="DISPLAY: inline;".

Comment 5

[Alice0775 White]

Attachment: archive zip, Open index.html

An error in Error Console

Error: TypeError: Value not an object.
Source file: https://reservia.viarail.ca/include/js/functions.js?_=1.60.1
Line: 110


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/1caa3c482541
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121001015518
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/64236acfaa80
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121001021018
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1caa3c482541&tochange=64236acfaa80

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Peter, looks like you didn't update your IDL file after <https://www.w3.org/Bugs/Public/show_bug.cgi?id=18503> was fixed.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 667562 [details] [diff] [review]
Patch v1

r=me.  It gladdens my heart to see how much code change was involved here.  ;)

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/416356bb2602