Closed Bug 797192 Opened 12 years ago Closed 9 years ago

Update Plugin Check Site

Categories

(Websites :: plugins.mozilla.org, defect)

Product:
Websites
Component:
plugins.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: igarcia, Assigned: espressive)

References

Details

(Whiteboard: u=dev c=content p=3) 

We need to update the Plugin Check site.

I'm adding this bug as a tracker.

More info: https://etherpad.mozilla.org/D0BDUL8l9e

Assigning it to Schalk based on Laura's request.
We have the design and we should be able to move forward with the actual implementation. See https://bugzilla.mozilla.org/show_bug.cgi?id=796204 for PSD of the new design.

For the Firefox Download button:

- Show the Firefox Download button only when the browser is outdated or the site is access with a different browser (Chrome, IE, Opera, etc). At the moment it shows us for everyone and is distracting.
Awesome stuff! Will take a look and get started.
One quick question I have is whether this should be integrated into bedrock or whether this is a standalone 'wpp/site'? If standalone, are we simply going to do this from scratch using Playdoh or is there a code base that will be used as the basis?
Flags: needinfo?(igarcia)
Good point.

This has more to do with the browser than with www.mozilla.org so I think it's a better idea to create it as a separate entity.

I'm wondering if we know where the code of the actual site lives. (www.mozilla.org/en-US/plugincheck/) We should inherit the majority of the logic of that site.

I know that Kev wanted some additional changes to the back-end, so him or Tomcat can have more requirements.
Flags: needinfo?(igarcia)
From what I know it lives in AMO, but needs to be moved out. So a new playdoh site would make a lot of sense unless it needs to remain PHP for some reason.
AFAIK there's no reason not to migrate to Playdoh. At least from my side I have no interest to keep it on PHP.
:ibai

I found the current code base for plugin check:
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/plugincheck/

There is in face no back-end and everything is client side so, we do not even have to go the playdoh route. I am gonna start a new repo for the plugincheck site and get cracking.
Even though I created a repo, I think the best home for the plugin check page will be inside Bedrock as a separate app. Thoughts?
I honestly have no preference. I see that it will be more organized that way. Who owns Bedrock?
(In reply to :ibai from comment #10)
> I honestly have no preference. I see that it will be more organized that
> way. Who owns Bedrock?

Talk to Chris More...he can help.
The code for the new plugincheck is 90% complete and a request for a dev server has been logged. The app is now a standalone Playdoh app and uses an updated version of Perfidies of the Web to build the plugincheck.js and plugincheck-badge.js files.
I don't see any reason this shouldn't be in bedrock. Seems like a waste to setup new infra for a static page or two. This is bedrock's wheelhouse.
After looking at the mockups on the design bug it's clear that this should absolutely be in bedrock. We have helpers for the download buttons, and the newsletter signup at the bottom and overall blue sandstone design come for free.
I have moved this into Bedrock.
(In reply to :ibai from comment #1)
> We have the design and we should be able to move forward with the actual
> implementation. See https://bugzilla.mozilla.org/show_bug.cgi?id=796204 for
> PSD of the new design.
> 
> For the Firefox Download button:
> 
> - Show the Firefox Download button only when the browser is outdated or the
> site is access with a different browser (Chrome, IE, Opera, etc). At the
> moment it shows us for everyone and is distracting.

How do we know it is the latest version of Firefox? Is there a property on navigator object one can check or perhaps navigator.buildID?
(In reply to Schalk Neethling [:espressive] from comment #16)
> How do we know it is the latest version of Firefox? Is there a property on
> navigator object one can check or perhaps navigator.buildID?

We do something similar on /firefox/whatsnew/. Up-to-date Fx sees the page, other Fx versions are redirected to the update page, and other browsers go to a new download page.

https://github.com/mozilla/bedrock/blob/master/apps/firefox/views.py#L70

So I'd detect this in the view and set a context var to show the button or not.
Created tracking bug tracking all current bugs against plugincheck: https://bugzilla.mozilla.org/show_bug.cgi?id=821279
Whiteboard: u=dev c=content p=3
Component: Pages & Content → plugins.mozilla.org
Product: www.mozilla.org → Websites
QA Contact: cbook
Why was this moved to the Websites product? Unless something has changed this page is going on www.mozilla.org.
Kohei: Why did you move this from www.mozilla.org to Websites? This page is being part of Bedrock.
Just curious - when will this new design be live?
I am aiming for early next week unless there are any major issues.
BTW, so far it is going as planned
What is the ETA on this page going live?
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/06b40a7df3701644ff08f59ab48f4e446050225c
Bug 797192: Revert apache passthrough for plugincheck.

This reverts commit e6c6bb066562396a55e6d6c571405c105edda45b.
Last-second decided to postpone until we can roll all locales at once (hence the roll back in comment #26). Please reopen when ready.
Resolution: FIXED → INCOMPLETE
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ecfa90aa6e258a7772069043debbc1f38d06d563
Bug 797192: Add apache passthrough for plugincheck.

en-US only so far.
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/f93fa80ec6e02ca4ba7cc1df01af6845d3cbc390
Bug 797192 - some CSS fixes for plugincheck page

Adjusted column widths and margins.
Improved responsiveness.

https://github.com/mozilla/bedrock/commit/5d5b7e6c62e9f97e62ce76a0b1c78e0702ad5b80
Merge pull request #770 from craigcook/master

 Bug 797192 - some CSS fixes for plugincheck page
fixed for en-US on stage. https://www.allizom.org/en-US/plugincheck/ for push on 04/11/2013
Depends on: 707493
I'm monitoring the traffic to this page on GA and it is looking stable. I will report in another week if the load time from the end user's perspective is higher or lower.
Did anyone consider dropping the bottom section about the banners and just sending users over to affiliates.mozilla.org where they can sign up for a plugin checker banner, get the code, track clicks, and more? It would also make the page lighter and smaller, which is helpful on a page like this.
(In reply to Chris More [:cmore] from comment #32)
I think :mkelly did mention this at one point, not sure if it was an official suggestion. I like it though. +1
(In reply to Paul McLanahan [:pmac] from comment #33)
> (In reply to Chris More [:cmore] from comment #32)
> I think :mkelly did mention this at one point, not sure if it was an
> official suggestion. I like it though. +1

yeah good point, will file a bug for this
(In reply to Chris More [:cmore] from comment #31)
> I'm monitoring the traffic to this page on GA and it is looking stable. I
> will report in another week if the load time from the end user's perspective
> is higher or lower.

Thanks Chris! Interested to hear the results of this.
(In reply to Chris More [:cmore] from comment #32)
> Did anyone consider dropping the bottom section about the banners and just
> sending users over to affiliates.mozilla.org where they can sign up for a
> plugin checker banner, get the code, track clicks, and more? It would also
> make the page lighter and smaller, which is helpful on a page like this.

If affiliates.mozilla.org does carry the badges for plugincheck, then I totally +1 removing it. It would be one of the easiest and quickest performance wins ever ;)
Depends on: 865590
(In reply to Schalk Neethling [:espressive] from comment #36)
> If affiliates.mozilla.org does carry the badges for plugincheck, then I
> totally +1 removing it. It would be one of the easiest and quickest
> performance wins ever ;)

filed bug 865590 to track this
+1 to move affiliates.
Depends on: 866046
ok reopen 

we will push (in coordination with pascal) de, sv-SE, eu, it to the new page
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Depends on: 892807
Status: REOPENED → RESOLVED
Closed: 11 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.