797318 - 'Build' and 'test run' filter captions aren't immediately obvious

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Ed Morley [:emorley]]

On the main OrangeFactor bug table/graph view, there are three dropdowns for filtering:
* platform
* build
* test run

Platform is obvious, however 'build' and 'test run', imply to me something more like filtering by push/build-id/revision etc rather than 'build type' (pgo/debug/opt) and 'test suite' (reftest,mochitest,...).

Comment 1

[Ed Morley [:emorley]]

(For 'test run': Particularly since we use "test run count" as a caption in the graph to refer to number of pushes; rather than the test suite)

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

* s/build/build type/
* s/test run/test suite/

Comment 3

[Ed Morley [:emorley]]

Attachment: Patch v2

Also changes the bug details table column caption from "Test" to "Test Suite".

Comment 4

[Mark Côté [:mcote]]

Comment on attachment 667882 [details] [diff] [review]
Patch v2

Review of attachment 667882 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but can you also update the dropdown on the Bug Count view?

Comment 5

[Ed Morley [:emorley]]

(In reply to Mark Côté ( :mcote ) from comment #4)
> Looks good but can you also update the dropdown on the Bug Count view?

I think we discussed this on IRC at the time, but recording here for posterity. The dropdowns are generated from the dataset, so it's not a simple substitution, so isn't worth the time:reward at the moment, given the years of sheriffing maintenance defficit on TBPL et al.

Landed the attached patch to get this bug out of my assigned bugs query":
http://hg.mozilla.org/automation/orangefactor/rev/d0474b5c2876

And I'll file a followup to make the bug count view change.

Comment 6

[Ed Morley [:emorley]]

Needs deploying, but can wait for next push :-)