797525 - Upgrade clang to version >= r163716 to fix ASan issue 109

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Christian Holler (:decoder)]

The bug at http://code.google.com/p/address-sanitizer/issues/detail?id=109 is a crasher for Firefox and it was fixed in r163716, so it would be good to have this on try for Mac and Linux available.

Comment 1

[Christian Holler (:decoder)]

Ccing Jesse who originally reported this to the ASan people, and Chris Peterson who is hitting this on Mac with our prebuilt binaries right now.

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: update the build script

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: update manifests

Try running at
https://tbpl.mozilla.org/?tree=Try&rev=bb656883e9ee

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1ac3154b40e

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f3ed2f39050

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

The diff-talos results I go on try:

dromaeo_css
MacOSX 10.6 (rev4)                | (3071.358,     16.6182586611)  -> (3137.845,     29.0318576198)  1.0216x better
MacOSX 10.7                       | (3037.302,     22.0994287753)  -> (3113.278,     20.9159235349)  1.0250x better

dromaeo_dom
MacOSX 10.6 (rev4)                | (240.5802,     0.985466158772) -> (244.166,      1.58043924834)  1.0149x better

sunspider
MacOSX 10.6 (rev4)                | (316.88,       1.01869896946)  -> (314.05,       0.834184643307) 1.0090x better

tp5n_paint
MacOSX 10.8                       | (177.8372,     0.501903333304) -> (176.5077,     0.499483614473) 1.0075x better

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e1ac3154b40e
https://hg.mozilla.org/mozilla-central/rev/2f3ed2f39050