797700 - Restrict the height/width of the ambient notification icons to 16x16

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

On Windows the images of the ambient notification icons will expand to show the image at full resolution. Mac only does this on hidpi mode, and Linux handles this using max-height.

This patch should fix all three platforms to be consistent, while also allowing hidpi mode to work correctly on Mac.

Frank, can you take a look at the HiDPI change on Mac?

Comment 1

[Frank Yan (:fryn)]

Comment on attachment 667842 [details] [diff] [review]
Patch

Review of attachment 667842 [details] [diff] [review]:
-----------------------------------------------------------------

As we discussed on IRC, the @media (min-resolution: 2dppx) block should simply be removed.
It was my mistake to add that block in the first place.
Thanks for flagging me. No need to flag me for the next version of the patch. :)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v1.1

Thanks for the feedback Frank. I removed the HiDPI block.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d24b8e3c078

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8d24b8e3c078

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: aurora patch

Minus the hidpi changes.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/95338d6f75fe