797817 - Otoro LED stays lit after disconnecting from mains following full charge

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ben Francis [:benfrancis]]

Device: Otoro

STR:
* Charge the device until it is fully charged
* Unplug from charger

Expected:
I'm not actually sure what is supposed to happen, but I'm guessing the green LED lights up to tell you that the device is fully charged, then should turn off when you unplug the device from the charger?

Actual:
LED turns on once fully charged, but when you unplug it stays lit until you next reboot.

Side note:
I'm actually curious to know where this code lives and how much control we have over the LED. I've seen some interesting looking drivers hanging around in the codebase and wondered if we could use the LED for other things too (like flashing/pulsing for notifications).

Comment 1

[Andrew Overholt [:overholt]]

I feel like this didn't used to happen.  Either way, sounds very bad :)

Comment 2

[Andrew Overholt [:overholt]]

s/didn't used to happen/wasn't the behaviour in the past/  Man, poor grammar today.

Comment 3

[Andrew Overholt [:overholt]]

I can still reproduce this.

Comment 4

[Benjamin Chen [:bechen]]

Attachment: Update the battery indicator led when receiving battery status change.

Comment 5

[Benjamin Chen [:bechen]]

try server link

https://tbpl.mozilla.org/?tree=Try&rev=a3e50457f62f

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 673772 [details] [diff] [review]
Update the battery indicator led when receiving battery status change.

Looks great!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2e341820373

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2e341820373

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/29fbf1fd2cb6