797945 - Nested <embed> tags cause "overlayText is null" in gPluginHandler::handleEvent::PluginClickToPlay

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Set
     user_pref("plugins.click_to_play", true);
2. Load the testcase

JavaScript error: chrome://browser/content/browser.js, line 3142: overlayText is null

http://hg.mozilla.org/mozilla-central/annotate/4cb8f88213f5/browser/base/content/browser-plugins.js#l169
>        let overlayText = doc.getAnonymousElementByAttribute(plugin, "class", "msg msgClickToPlay");
>        overlayText.textContent = messageString;

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

This looks to me like another case where the binding doesn't get attached when it should. Either that or we're loading the plugin again when we're not supposed to.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Which element is the binding not being attached to?  The inner <embed> never gets a frame, of course....  Would that matter here?

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

The inner <embed> is not getting the binding, which makes sense if it never gets a frame. However, we're still firing the PluginClickToPlay event for it, which I think might not be right.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, that seems a bit odd, since it will never actually be clickable, ever.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I'm pretty sure this was fixed by bug 800018. Should we add this testcase to the test suite so we (in theory) don't regress?