798423 - spdy enable reading of ping reply

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

I noticed when reading logs for bug 790184 that some idle spdy sessions were failing their keep alive checks when networking appeared to be working fine.

it turns out when we generate a ping sometimes mSocketIn is not set to read data and so the ping reply is queued without being read and eventually the session times out.

This results in tearing down idle sessions more aggressively than we intend to.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 668489 [details] [diff] [review]
patch 0

Review of attachment 668489 [details] [diff] [review]:
-----------------------------------------------------------------

Ooops!  This was really missing!

Comment 3

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39d7c39c6ac2

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/39d7c39c6ac2

Comment 5

[Patrick McManus [:mcmanus]]

Comment on attachment 668489 [details] [diff] [review]
patch 0

790184 was r? for FF17, and this patch should go with it to ensure full efficacy. This patch is very low risk.

Comment 6

[Patrick McManus [:mcmanus]]

  https://hg.mozilla.org/releases/mozilla-beta/rev/8bc762ccc4ea

Comment 7

[u279076]

Is there something QA can do here to verify this is fixed?

Comment 8

[Ed Morley [:emorley]]

(These dependants were mis-added to bug 798243 due to the wrong bug number being in the commit message)