798715 - [Email] Need errors thrown when sending emails with no Email addresses

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Tony Chung [:tchung]]

No errors are shown when sending an email with no address in To, cc or bcc line.   Instead, it acts like the message was sent and returns user to the inbox.

Environment:
- 10/5 daily otoro build
- gaia: ca1f327d5acc198bb4be62fa51db2c039032c9ce
- gecko: ddc8eeb3f9b9ee04d9f74b4f60522eb4530a4a6f

Repro:
1) launch email and add an account (gmail)
2) hit compose
3) do not enter any email addresses in the To, CC, or bcc line.
4) Hit Send
5) Verify a message does not error out, instead acts like its sent and returns to inbox.

Expected:
- in app messaging throwing errors if no email addresses are included

Actual:
- message seems like its been sent to someone.

Comment 1

[Steve Chung [:steveck]]

Hi Casey, do we need to apply any other error handling for no sender case, or just use 'Sent failed' in toaster like other sent failed scenario?

Comment 2

[Steve Chung [:steveck]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/5826

Comment 3

[Kai-Chih Hu [:khu]]

Casey, it looks like we need your help to update the wireframes and see how we should do here. You may refer to https://github.com/mozilla-b2g/gaia/pull/5826.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 671720 [details]
https://github.com/mozilla-b2g/gaia/pull/5826

This pull request got repurposed and landed as part of bug 804916, clearing review requests.

This bug may end up just being entirely covered by bug 804907 since it changes up our sending style to be synchronous.  Steve, I've marked you as the assignee for that bug.

Comment 5

[Steve Chung [:steveck]]

Attachment: Patch for adding new dialog to notify of send failure

Comment 6

[Steve Chung [:steveck]]

Hi Casey,
Since there is no wireframe for the sent failed flow, please feel free to create the polish issue if this prototype is far from your design, thanks.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 677293 [details]
Patch for adding new dialog to notify of send failure

Clearing review request since we are taking care of this on Bug 804907.

Comment 8

[mlevin]

On Unagi Build 20121231070201 the button to send is grayed out until the User places an address in one of the fields, thus the e-mail cannot be sent if no recipient is entered in the To, cc, bcc fields.