Closed Bug 798965 Opened 12 years ago Closed 12 years ago

Avoid using gPrivateBrowsingUI.privateBrowsingEnabled in browser.js and use the per-window PB API instead

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

      No description provided.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #668952 - Flags: review?(josh)
Comment on attachment 668952 [details] [diff] [review]
Patch (v1)

Review of attachment 668952 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming this is applied on top of a patch that adds a PrivateBrowsingUtils.jsm import, since MXR shows none.
Attachment #668952 - Flags: review?(josh) → review+
(In reply to comment #2)
> Comment on attachment 668952 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=668952
> Patch (v1)
> 
> Review of attachment 668952 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me assuming this is applied on top of a patch that adds a
> PrivateBrowsingUtils.jsm import, since MXR shows none.

Yep, that's bug 798516.
(which is awaiting your review ;)
https://hg.mozilla.org/mozilla-central/rev/fa5fa35e15df
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: