798966 - Bypass getUserMedia permissions with a pref

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Anant Narayanan [:anant]]

A preference to bypass permissions for gUM would be very useful. Additionally, permissions are being (incorrectly) asked for fake streams.

Comment 1

[Anant Narayanan [:anant]]

Attachment: Add pref to disable permission check

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 668959 [details] [diff] [review]
Add pref to disable permission check

Ok, and this fixes the permission request for fake media streams bug as well.

Can I say I hate the names we chose for getUserMedia preffing?  Luckily they (or at least media.navigator.enabled) will go away eventually.  :-)

r+

No privacy review needed since the getUserMedia is preffed off currently.  When preffed on, we'd need to run this by privacy.

Comment 3

[Anant Narayanan [:anant]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/959de7eea1ff

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Anant Narayanan [:anant] from comment #0)
> A preference to bypass permissions for gUM would be very useful.
> Additionally, permissions are being (incorrectly) asked for fake streams.

Anant, just a note here. Why are those incorrectly shown? At least for the testing mode we need those notifications, otherwise nothing can be tested. So I would vote for that we do not remove them.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/959de7eea1ff

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> Anant, just a note here. Why are those incorrectly shown? At least for the
> testing mode we need those notifications, otherwise nothing can be tested.
> So I would vote for that we do not remove them.

As a workaround tests can enable the pref for testing purposes. So I think we are fine here.

Comment 7

[Anant Narayanan [:anant]]

Just to be clear, the pref is to *disable* the permission dialog, not enable it. The default is (of course) to always ask for permission.

Comment 8

[Jason Smith [:jsmith]]

Verified in 10/12 Nightly build.