Closed
Bug 799199
Opened 12 years ago
Closed 12 years ago
Use IndentBy() instead of looped "fputs" in ns*Frame::List methods
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
2.24 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
There are a few places in layout code where we have something like
> for (int32_t i = aIndent; --i >= 0; ) fputs(" ", out); // Indent
but we generally use the utility method nsFrame::IndentBy() to accomplish this in one centralized implementation. I suspect the hardcoded-fputs-loops predate IndentBy(), and they were never switched over.
Filing this bug on replacing the fputs-loops with IndentBy() calls.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #669231 -
Flags: review?(bzbarsky)
Comment 2•12 years ago
|
||
Comment on attachment 669231 [details] [diff] [review] fix r=me
Attachment #669231 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b177c32d57d6
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b177c32d57d6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•