Closed Bug 79922 Opened 23 years ago Closed 23 years ago

Name modification isn't updated immediately

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: yulian, Assigned: srilatha)

References

Details

(Whiteboard: Have a fix,r=,sr=,a=)

Attachments

(4 files)

Netscape 6.5/2001050914 build

1. Modify Name in New Directory| General
2. OK  to New Directory dialog
3. The Name listed in LDAP Directory Servers dialog is not updated
4. Close out LDAP Directory Servers dialog
5. Click on Edit Directories button
6. The updated Name then shows up
QA Contact: esther → yulian
Priority: -- → P2
Target Milestone: --- → mozilla0.9.2
Blocks: 17880
Priority: P2 → P3
Attached patch patch v1Splinter Review
ccing Bhuvan for review
ccing Seth for sr
Status: NEW → ASSIGNED
Whiteboard: Have a fix, requesting review
now ccing
r=mohanb; 
+    dump("gNewServer is " + gNewServer + "\n"); 

Srilatha, please don't add new dumps to the tree.
ok, r=mohanb;
Whiteboard: Have a fix, requesting review → Have a fix, r=, need an sr=
+  if(gRefresh) 
+  { 
+    var directoriesTree = document.getElementById("directoriesTree"); 
+    var selectedNode = directoriesTree.selectedItems[0]; 
+    var row  =  selectedNode.firstChild; 
+    var cell =  row.firstChild; 
+    cell.setAttribute('label', gNewServer); 
+    cell.setAttribute('string', gNewServerString);
+    window.opener.gRefresh = true; 
+  } 


it seems like that should be:

+    window.opener.gRefresh = false;
+  }

or am I confused?
Whiteboard: Have a fix, r=, need an sr= → Have a fix, requesting review
+  if(gRefresh) 
+  { 
+    var directoriesTree = document.getElementById("directoriesTree"); 
+    var selectedNode = directoriesTree.selectedItems[0]; 
+    var row  =  selectedNode.firstChild; 
+    var cell =  row.firstChild; 
+    cell.setAttribute('label', gNewServer); 
+    cell.setAttribute('string', gNewServerString);
//You are right. here I need to have gRefresh = false;
+    window.opener.gRefresh = true; 
but the window.opener is for either Addressing Panel in global preferences
or ServerSettings panel in Mail/News Account Settings. 
I need to have window.opener.gRefresh = true so that the dropdown list box in 
the above mentioned panels will be refreshed.
Will post a patch with the change right away.
Attached patch updated patchSplinter Review
I *think* I understand what you're doing here, but it's pretty confusing.

you should comment this code so it's clear why you set gRefresh to false, but
window.opener.gRefresh to true.

having them be the same name (gRefresh) adds to the confusion.  I recommend
renaming these so it's clear what they are going to refresh.

another, cleaner approach would be to have a method that does the "refresh",
instead of setting globals like this.
Attached patch updated patchSplinter Review
Sorry, for the confusion. I have added comments and also updated one gRefresh to 
gUpdate.
sr=sspitzer, assuming mohanb is ok with it.
r=mohanb;
Whiteboard: Have a fix, requesting review → Have a fix,r=,sr=, need a=
Blocks: 83989
a=dbaron for trunk checkin (on behalf of drivers)
Whiteboard: Have a fix,r=,sr=, need a= → Have a fix,r=,sr=,a=
Fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified with 2001061304 winds trunk build
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: