799247 - Adjust message in nsITransferable compatibility flag

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

The message I proposed in bug 795423 has been pointed out to be incorrect in many cases, so we need to make some adjustments. The bump has already been made, so most developers will have seen the old message already, but we should correct it for future validations.

New Message:

The nsITransferable interface has changed to better support Private Browsing Mode. After instantiating the object, you should call the init function on it before any other functions are called. See <LINK> for more information.

New Link: https://developer.mozilla.org/en-US/docs/Using_the_Clipboard

Comment 1

[Justin Watt]

Jorge, just want to point out here as well in bug 722872 that it's unclear in the recent edits to https://developer.mozilla.org/en-US/docs/Using_the_Clipboard where the "sourceWindow" var comes from.

Also, while I'm at it, some of the code samples on that page seems to have gotten badly munged (probably on transition from one CMS to another), resulting in HTML (like strong tags) showing up erroneously in the code samples, e.g.

<strong>// make a copy of the Unicode</strong>

Comment 2

[Josh Matthews [:jdm]]

Jorge, is there some way to send out the compatibility warning again? The existing message totally negates the purpose of the change and could lead to private data being kept alive after leaving private browsing.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

That would be confusing for developers, and they would probably disregard it as a duplicate.

Comment 4

[Josh Matthews [:jdm]]

Isn't there some messaging we could prefix it with to make it clearer? This is a really unfortunate situation, and I don't see why we need to just throw our hands up in despair.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

You're right. We'll look into that once this bug is fixed in production.

Comment 6

[Kris Maglione [:kmag]]

We should probably also add a warning when nsITransferable.init() is called with null as the first argument.

Comment 7

[Josh Matthews [:jdm]]

Unfortunately null is valid in a number of common situations, so that's not workable.

Comment 8

[Kris Maglione [:kmag]]

The validator warns for a lot of things that are valid in a number of common situations. nsITransferable.init(null) is the kind of thing that developers and editors should think twice about, so it's the kind of thing we should warn for.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

Kris, please file a separate bug for that, since it isn't a compatibility check.

Comment 10

[Matt Basta [:basta]]

Messaging updated:

https://github.com/mozilla/amo-validator/commit/db11baaba76765de59e9072b8ad3bcb3560ed36b

Comment 11

[Kris Maglione [:kmag]]

Filed bug 800495.

Comment 12

[Matt Basta [:basta]]

If there's anything else, let me know.

Comment 13

[Jorge Villalobos [:jorgev] (he/him)]

The updated compatibility bump message was sent earlier today.