799537 - move xpconnect chrome mochitests in tests/mochitest to tests/chrome

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[foudfou]

js/xpconnect/tests/mochitest/Makefile.in has a MOCHITEST_CHROME_FILES section, whereas chrome mochitests should be in js/xpconnect/tests/chrome/.

Comment 1

[foudfou]

Attachment: patch v0

test_bug760131.html, previously referenced as a chrome test, is obviously a plain mochitest.

Comment 2

[foudfou]

Attachment: sorting MOCHITEST_FILES

while at it, here is my attempt to sort MOCHITEST_FILES.

I'll merge both patches appropriately.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Maybe we should just merge those folders.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 669594 [details] [diff] [review]
patch v0

test_bug760131.html is actually a chrome test, even though it's not a .xul file. So it shouldn't be moved to MOCHITEST_FILES.

Comment 5

[foudfou]

Attachment: patch v1

got it ! Here is a new patch with light sorting of MOCHITEST_FILES in tests/mochitest/Makefile.in included.

Comment 6

[Bobby Holley (:bholley)]

Hm, why do file_bug795275.html and such move up in the list? Can we keep everything in sorted order according to bug number? (that is to say, test_123 and file_123 together).

Comment 7

[foudfou]

Attachment: patch v2 -- another try

not easy to keep everything sorted according to bug number since file naming is not consistent, but here is another try.

Comment 8

[Bobby Holley (:bholley)]

Comment on attachment 673357 [details] [diff] [review]
patch v2 -- another try

test_bug361111.xul never gets removed from the other list here as far as I can tell.

Maybe first do a patch that just moves the mochitest-chrome files, and then a second patch that does the sorting?

Comment 9

[foudfou]

Attachment: patch v3 -- part 1 - Move

Comment 10

[foudfou]

Attachment: patch v3 -- part 2 - Sorting

Comment 11

[Bobby Holley (:bholley)]

Comment on attachment 673412 [details] [diff] [review]
patch v3 -- part 1 - Move

r=bholley

Comment 12

[Bobby Holley (:bholley)]

Comment on attachment 673416 [details] [diff] [review]
patch v3 -- part 2 - Sorting

Erg, hrm - doesn't appear to be sorted? Stuff like file_mozMatchesSelector.html is mixed in with the other stuff.

Basically, the stuff with the bug numbers in it should all be together, sorted by bug number, and everything else should be alphabetical. Sorry if that was unclear, and that this is turning out to be so finicky. :-(

Comment 13

[foudfou]

Attachment: patch v4 -- part 2 - Sorting

Oh I see. I previously put file_mozMatchesSelector.html btw. file_bug505915.html and test_bug553407.html because it was related to bug 533596. But a visual sorting makes sense.

Comment 14

[Bobby Holley (:bholley)]

Comment on attachment 673431 [details] [diff] [review]
patch v4 -- part 2 - Sorting

parfait ;-) r=bholley

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0fd262da49b
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d0616db8d20

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f0fd262da49b
https://hg.mozilla.org/mozilla-central/rev/8d0616db8d20