799643 - Current comm-central builds of GData extension use old and incorrect version 0.2pre

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Stefan Sitter [:ssitter]]

Todays comm-central build of the of GData extension based on mozilla19 source code will identify itself as version 0.2pre.

Version 0.2 of the GData extension was already released in 2007. Current version number should be higher ;)

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Looks like this kind of bug is biting me everywhere :) This patch should fix it, at least until 0.100 ;-)

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 7f1a33a6e03b

Comment 3

[Stefan Sitter [:ssitter]]

Somehow it didn't work on the Linux build server. The install.rdf file contains only 
<em:version></em:version> without any version information. The Mac OS X build seems OK.

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to Stefan Sitter from comment #3)
> Somehow it didn't work on the Linux build server. The install.rdf file
> contains only 
> <em:version></em:version> without any version information. The Mac OS X
> build seems OK.

Yes, to be precise: both L32 and L64 builds lack the version information. The Mac build has <em:version>0.20pre</em:version> as expected. No W32 build was produced (the latest one was on 18 October), which is of course a different bug.

Comment 5

[Tony Mechelynck [:tonymec]]

This reminds me of a change I've seen in another file: http://hg.mozilla.org/hgcustom/hghooks/rev/e7d2ca6c9aee#l1.28

What is the Python version of the linux builders?

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Mac uses python 2.7 since the new slave is around, Linux uses 2.6 since today and 2.5 before, Windows uses 2.7 since today and 2.5 before.

Comment 7

[Tony Mechelynck [:tonymec]]

(In reply to Philipp Kewisch [:Fallen] from comment #6)
> Mac uses python 2.7 since the new slave is around, Linux uses 2.6 since
> today and 2.5 before, Windows uses 2.7 since today and 2.5 before.

So Linux builders are on an older version than the rest. See also bug 803834 comment #3.

Comment 8

[Stefan Sitter [:ssitter]]

Philipp, could you provide a patch that works with Python 2.6? As long as this version is supported by the build system we should support it too.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Additional Fix

I've tested this with python 2.6 and 2.7, it should work.

Comment 10

[Stefan Sitter [:ssitter]]

Comment on attachment 677709 [details] [diff] [review]
Additional Fix

The original problem and its patch were only checked in to comm-central (Lightning 2.1) therefore I see no need to port it back to aurora and beta.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 677709 [details] [diff] [review]
Additional Fix

Oh, right. Thanks for the reminder!

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset f919289ef9c8