799749 - Add back the Show Desktop Notifications menuitem for the Social API toolbar menu

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

The patch for bug 790112 accidentally removed the Show Desktop Notifications toolbar menuitem. This patch adds it back, along with a test to make sure this doesn't happen again.

This affects Firefox 17 and 18 as well, but the patch is minimal and doesn't introduce any strings. The strings weren't removed on accident, just the menuitem.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 669779 [details] [diff] [review]
Patch

It would be even better if the test checked the menuitems did something :)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for checkin

Also fixed the toolbar icons in the other tests. Ok'd by Mark on IRC,
5:08 PM <jaws> markh: ok for me to fix the toolbar icons when i push the menuitem fix?
5:09 PM <markh> fine with me :)
5:10 PM <jaws> i mean the toolbar icons in the tests of course
5:10 PM <jaws> they're currently using 48x48 icons, which doesn't seem right

The tests don't check the "checked" state toggling due to bug 799761.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88bb0e2f0373

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/88bb0e2f0373

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/663a97922297
https://hg.mozilla.org/releases/mozilla-aurora/rev/24d2399d1ca1

Comment 6

[u279076]

Verified fixed across all branches.