799810 - Send puppet reports from AWS puppet masters to puppet dashboard

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Comment 1

[Rail Aliiev [:rail]]

Per http://docs.puppetlabs.com/dashboard/manual/1.2/bootstrapping.html#using-dashboard-for-reports we need the following in puppet.conf
[master]
 reports = store, http
 reporturl = http://dashboard.example.com:3000/reports/upload

Probably would be great to puppetize this.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

In our case, it's

    reports = tagmail, http
    reporturl = http://puppetdash.pvt.build.mozilla.org/reports/upload

Comment 3

[Rail Aliiev [:rail]]

Attachment: [WIP] reports

Not tested

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Looks good, but whats this?
+$extlookup_precedence = ["domain_%{domain}", "local-config", "default-config", "secrets"]

Comment 5

[Rail Aliiev [:rail]]

(In reply to Dustin J. Mitchell [:dustin] from comment #4)
> Looks good, but whats this?
> +$extlookup_precedence = ["domain_%{domain}", "local-config",
> "default-config", "secrets"]

Probably I should drop that and use local-config instead for master specific customizations. Wanted to have something generic for aws masters, but probably it'll be harder to read/follow the configs in this case.

Comment 6

[Rail Aliiev [:rail]]

Attachment: reports

I tested this with 'puppet apply .. --noop --show_diff --diff diff --diff_args "-u" ...'. The diff looks quite sane:

Default:

+    reports = tagmail
+    reporturl = http://dashboard.example.com:3000/reports/upload

and

+    reports = tagmail,http
+    reporturl = http://puppetdash.pvt.build.mozilla.org/reports/upload

if I put the following into local-config:
puppet_server_reports,"tagmail,http"
puppet_server_reporturl,http://puppetdash.pvt.build.mozilla.org/reports/upload

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 670380 [details] [diff] [review]
reports

Review of attachment 670380 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, looks good!

::: manifests/extlookup/default-config.csv
@@ +11,5 @@
>  crl_sync_url,
>  puppet_again_repo,http://hg.mozilla.org/build/puppet
>  global_authorized_keys,
> +puppet_server_reports,tagmail
> +puppet_server_reporturl,http://dashboard.example.com:3000/reports/upload

This example should probably be blank?  I don't think we want to accidentally send reports to example.com :)

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 670380 [details] [diff] [review]
reports

http://hg.mozilla.org/build/puppet/rev/4ffe43d3857a

(In reply to Dustin J. Mitchell [:dustin] from comment #7) 
> This example should probably be blank?  I don't think we want to
> accidentally send reports to example.com :)

I changed that to "http://localhost:3000/reports/upload" which is default per http://docs.puppetlabs.com/references/latest/configuration.html#reporturl