Closed
Bug 799913
Opened 12 years ago
Closed 10 years ago
Remove support for the Zapf Dingbats encoding and other dead-code encoder-only encodings
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: hsivonen, Assigned: hsivonen)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
68.99 KB,
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
We have support for x-zapf-dingbats but it does not appear to be exposed to the Web or used in font code: http://mxr.mozilla.org/mozilla-central/ident?i=zapf&tree=mozilla-central&filter= It was added by Frank Tang in 1999 with the helpful comment “add unicode encoders”. Let’s remove it.
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → hsivonen
Summary: Remove support for the Zapf Dingbats encoding → Remove support for the Zapf Dingbats encoding and other dead-code encoder-only encodings
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=7f9558ee41f8
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
Awesome. We've had bogus comments in a property file for a long time, but the entry after the comments was useless, so no one noticed. https://tbpl.mozilla.org/?tree=Try&rev=484564b87ce1
Attachment #8355179 -
Attachment is obsolete: true
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8355210 [details] [diff] [review] Remove dead code, fix property file comments It seems to me that these encodings exist, because year ago the X11 gfx code knew about font-specific encodings and this stuff wasn't fully removed when X11 gfx moved to FreeType2, etc.
Attachment #8355210 -
Flags: review?(VYV03354)
Updated•10 years ago
|
Attachment #8355210 -
Flags: review?(VYV03354) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks. https://hg.mozilla.org/integration/mozilla-inbound/rev/89b66dd9847a
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/89b66dd9847a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•