800123 - Don't hard code the contact photos in cardDialog

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Richard Marti (:Paenglab)]

The default Contact photos in cardDialog are hard coded in XUL and JS. This makes it impossible to add HiDPI images for Retina Macs and themers have to follow this name and path to show the images.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

I gave the menulist the value="default" and made the CSS selector matching this to be nice to Add-ons which add more default icons (Display Contact Photo).

Comment 2

[Richard Marti (:Paenglab)]

Attachment: patch v2

Oops, forgot the changes in addressbook.css which made the default photo not showing in AB.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 670770 [details] [diff] [review]
patch v2

Review of attachment 670770 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the wait! This looks good - I just think we should update a comment.

Thanks,

-Mike

::: mail/components/addrbook/content/abCommon.js
@@ +16,5 @@
>  const kDefaultDescending = "descending";
>  const kLdapUrlPrefix = "moz-abldapdirectory://";
>  const kPersonalAddressbookURI = "moz-abmdbdirectory://abook.mab";
>  const kCollectedAddressbookURI = "moz-abmdbdirectory://history.mab";
>  // The default image for contacts

Let's update this comment so that it says,

// The default, generic contact image is displayed via CSS when the photoURI is
// blank.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: patch for check-in

Patch addressing the review comment.

carrying over r+

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/5fe67c22b3e5