800157 - Make User Agent overrides affect navigator.userAgent in addition to the HTTP header

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Dão Gottwald [:dao]]

Bug 795348 might need this unless that site can be evangelized. Either way, it will be good to have the ability to override navigator.userAgent up our sleeve.

I suppose UserAgentOverrides.jsm needs to converted to an XPCOM service, or an XPCOM services utilizing UserAgentOverrides.jsm needs to be added, such that Navigator.cpp can use that. Does this sound reasonable?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Seems fine to me, yes.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Dão Gottwald [:dao]]

Attachment: override for testing

You can test this on <https://direktnet.raiffeisen.hu/rai/direktnet/home.do>. With the override applied, the login form should be present.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 670305 [details] [diff] [review]
patch

>+++ b/dom/base/Navigator.cpp
> Navigator::GetUserAgent(nsAString& aUserAgent)
>+  NS_ENSURE_SUCCESS(rv, NS_OK);

Second arg should be rv.

>+  nsCOMPtr<nsIDocument> doc = do_QueryInterface(win->GetExtantDocument());

  nsIDocument* doc = win->GetExtantDoc();

r=me with those.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch, review comments addressed

Comment 6

[Dão Gottwald [:dao]]

https://bugzilla.mozilla.org/attachment.cgi?id=670558

Comment 7

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #6)
> https://bugzilla.mozilla.org/attachment.cgi?id=670558

wrong link...

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f28c28e988f

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9f28c28e988f

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 670558 [details] [diff] [review]
patch, review comments addressed

[Approval Request Comment]

Extends our ability to react to sites that are broken due to bad UA sniffing.

Bug caused by (feature/regressing bug #): n/a
User impact if declined: n/a
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, I think
String or UUID changes made by this patch: none

Comment 10

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/717bd76378cc
https://hg.mozilla.org/releases/mozilla-beta/rev/3c067c8fb7fd