800187 - Add memory reporter for the nsStyleSheetService

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Nicholas Nethercote [inactive]]

bz and I thought adding a memory reporter for the style-sheet service might
help with B2G dark matter, but it didn't much -- it's 6KB for desktop and 
~50KB for B2G on start-up.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Add memory reporter for the nsStyleSheetService.

bz, does this look right?  I'll probably land this even though the amount is
so pathetic, just to make clear that we are measuring it.

Comment 2

[Nicholas Nethercote [inactive]]

I forgot to mention:  I modified nsLayoutStylesheetCache's reporter a little bit to make it consistent with the new reporter.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Note that with extensions like Stylish this number can be a lot bigger.

Comment 4

[Andrew McCreight [:mccr8]]

Bug 713216 shows a case with high heap-unclassified with stylish.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 670179 [details] [diff] [review]
Add memory reporter for the nsStyleSheetService.

Do we not need to delete or release mReporter?  If so, r=me, though I'd like to understand why we don't need to.

Comment 6

[Nicholas Nethercote [inactive]]

> Do we not need to delete or release mReporter?

We don't, because it gets put into an nsCOMArray that does the addref/release.  It's certainly not obvious, though...

Comment 7

[Gabor Krizsanits (INACTIVE)]

There is a little race between this patch and Bug 676054 which adds another sheet type to nsStyleSheetService (one more array to count with...). Do you want to land this patch first and let me update my patch? Or shall I commit first?

Comment 8

[Nicholas Nethercote [inactive]]

> Or shall I commit first?

It's Saturday here, and I won't land my patch until Monday.  So if you're ready to go now, please do and I'll update.

Comment 9

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d58328861bf3
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea223d8ba0f0

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d58328861bf3
https://hg.mozilla.org/mozilla-central/rev/ea223d8ba0f0