Closed Bug 800512 Opened 12 years ago Closed 5 years ago

outLen is uninitialized if Push() returns -1 (asynchronous mode) in Resampler::Insert() (webrtc.org code)

Categories

(Core :: WebRTC: Audio/Video, defect, P4)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: jesup, Unassigned)

References

Details

Assigned value is garbage or undefined	media /webrtc/trunk/src/common_audio/resampler/resampler.cc	1050

Insert() is not checking the result of Push(), which can fail and return -1 without setting outLen.

I don't know if the resampler is actually used in async mode.

This is an upstream issue for webrtc.org.
Also line 1038
Priority: -- → P3
Whiteboard: [WebRTC], [blocking-webrtc-]
backlog: --- → webRTC+
Rank: 35
Whiteboard: [WebRTC], [blocking-webrtc-]
Is this still relevant?
Flags: needinfo?(rjesup)
QA Contact: jsmith
Mass change P3->P4 to align with new Mozilla triage process.
Priority: P3 → P4

This seems to have been fixed some time ago.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Flags: needinfo?(rjesup)
You need to log in before you can comment on or make changes to this bug.