Closed
Bug 800525
Opened 12 years ago
Closed 12 years ago
wrapped nick causes extra height on secondary lines
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 19.0
People
(Reporter: mark.yen, Assigned: Mook)
Details
Attachments
(2 files, 1 obsolete file)
11.59 KB,
image/png
|
Details | |
544 bytes,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
When a user's nick wraps, that message line becomes double-height (to display the nick). However, when the nick is hidden (because it's a subsequent message from the same user), that extra height is still used. The attached patch switches it from visibility:hidden to display:none to avoid this.
Attachment #670518 -
Flags: review?(nisses.mail)
Reporter | ||
Comment 1•12 years ago
|
||
Updated•12 years ago
|
Attachment #670518 -
Flags: review?(nisses.mail) → review?(richard.marti)
Comment 2•12 years ago
|
||
Comment on attachment 670518 [details] [diff] [review] use display:none This looks good and does for what it is made. But it would be better to stop wrapping the nick. When a wrapped nick sends only a short sentence like 'ping' or 'okay', it still uses two lines for the nick. A .pseudo (white-space: nowrap;) would stop the wrapping and abbreviate the wrappable nicks like normal long nicks. Please could you do a patch like this? You can also include your first patch in the new patch.
Attachment #670518 -
Flags: review?(richard.marti) → review-
Actually, with .pseudo { white-space: nowrap; }, I don't even need the display: none change anymore; everything has at least one line anyway, so whether it's visibility: hidden or display: none doesn't matter very much. Of course, this means that if the _contents_ first line does wrap, the name still wouldn't. Ah well, I don't think there's a sensible way of fixing that.
Assignee: nobody → mook.moz+mozbz
Attachment #670518 -
Attachment is obsolete: true
Attachment #673109 -
Flags: review?(richard.marti)
Comment 4•12 years ago
|
||
Comment on attachment 673109 [details] [diff] [review] set white-space: nowrap on .pseudo This looks good. r+ Thank you for the patch
Attachment #673109 -
Flags: review?(richard.marti) → review+
Comment 5•12 years ago
|
||
setting checkin-needed will make this patch land in the tree.
Keywords: checkin-needed
Reporter | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/f3e37385c970 ... I hope I haven't screwed up pushing things!
Updated•12 years ago
|
Target Milestone: --- → Thunderbird 19.0
You need to log in
before you can comment on or make changes to this bug.
Description
•