800641 - Add mozfile to tests.zip

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jonathan Griffin (:jgriffin)]

mozfile isn't being packaged in tests.zip under mozbase, and this is causing Marionette runs on 10.8 to error out with:

15:31:40     INFO - Installing mozinstall into virtualenv /builds/slave/talos-slave/test/build/venv
15:31:40     INFO - Running command: ['/builds/slave/talos-slave/test/build/venv/bin/pip', 'install', '--find-links', 'http://puppetagain.pub.build.mozilla.org/data/python/packages', 'tests/mozbase/mozinstall'] in /builds/slave/talos-slave/test/build
15:31:40     INFO - Copy/paste: /builds/slave/talos-slave/test/build/venv/bin/pip install --find-links http://puppetagain.pub.build.mozilla.org/data/python/packages tests/mozbase/mozinstall
15:31:41     INFO -  Ignoring indexes: http://pypi.python.org/simple/
15:31:41     INFO -  Unpacking ./tests/mozbase/mozinstall
15:31:41     INFO -    Running setup.py egg_info for package from file:///builds/slave/talos-slave/test/build/tests/mozbase/mozinstall
15:31:41     INFO -  Requirement already satisfied (use --upgrade to upgrade): mozinfo==0.4 in ./venv/lib/python2.7/site-packages (from mozInstall)
15:31:41     INFO -  Downloading/unpacking mozfile (from mozInstall)
15:31:41     INFO -    Could not find any downloads that satisfy the requirement mozfile (from mozInstall)
15:31:41     INFO -  No distributions at all found for mozfile (from mozInstall)
15:31:41     INFO -  Storing complete log in /Users/cltbld/.pip/pip.log
15:31:41    ERROR - Return code: 1

I'm totally mystified why this is only a problem on 10.8, but fixing this bug and patching the Marionette mozharness script should fix it.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Add mozfile to mozbase packages in test.zip,

Should fix the problem.

Comment 2

[Jonathan Griffin (:jgriffin)]

And we'll see if try agrees:  https://tbpl.mozilla.org/?tree=Try&rev=6b82a045d5a6&noignore=1

Comment 3

[Jeff Hammel]

Yikes, I had forgotten about this awfulness.  We can (and should) check this in now, but we really need to generate this list dynamically, espec wrt the scary:

# python packages to be installed IN INSTALLATION ORDER.
# Packages later in the list can depend only on packages earlier in the list.

I'm not sure if anything depends on the install order right now, but this is ripe to be broken (since I'm sure everyone has been checking the tree and fixing this list every time a setup.py has changed, right?)

Ultimately we should not depend on this here, though fwiw setup_development.py figures out this information both dynamically and correctly (and with the existing in-tree system of virtualenv + .pth files, that should be fine too...as long as we list all of them which we currently don't since once again that's ripe for breaking)

Comment 4

[Jonathan Griffin (:jgriffin)]

So, the try run says this gets packaged correctly now. Marionette still fails on osx 10.8, but that's because we need a mozharness script change to pick up mozfile that's now in tests.zip.

Comment 5

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/mozilla-central/rev/c9b7e55872c9

Comment 6

[Jonathan Griffin (:jgriffin)]

Trying on ash:  https://tbpl.mozilla.org/?tree=Ash&rev=fe0e1387fee0

Comment 7

[Jonathan Griffin (:jgriffin)]

The run on ash looks good, pushed to aurora:  https://hg.mozilla.org/releases/mozilla-aurora/rev/c31b9aa6d4ad